[pcre2] Convert JIT to feature

[talregev]

Convert JIT to feature

• Changes comply with the maintainer guide
• SHA512s are updated for each updated download
• The "supports" clause reflects platforms that may be fixed by this new version
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[autoantwort]

It is currently not failing?

[talregev]

It is currently not failing?

vcpkg ci doesn't check arm64-osx triplet.

[autoantwort]

I have tested it locally

[talregev]

I have tested it locally

I tested it on osx on the github action ci. and it fail without this fix.

I also set these:

set(VCPKG_OSX_DEPLOYMENT_TARGET 10.13)
set(VCPKG_C_FLAGS -mmacosx-version-min=10.13)
set(VCPKG_CXX_FLAGS -mmacosx-version-min=10.13)

[autoantwort]

Can you provide the error logs?

[talregev]

Can you provide the error logs?

I will.

[autoantwort]

Ah I found it:

/Users/leanderSchulten/git_projekte/vcpkg2/buildtrees/pcre2/src/cre2-10.40-42fc341438.clean/src/sljit/sljitExecAllocator.c:156:2: error: "Must target Big Sur or newer"
#error "Must target Big Sur or newer"
 ^
1 error generated.

[autoantwort]

But then I suggest to make it a feature instead of turning it off completely because it only works on current macs.

[talregev]

But then I suggest to make it a feature instead of turning it off completely because it only works on current macs.

I will try to convert it to a feature.

[talregev]

@autoantwort Can you test my port and check I didn't make errors?

[talregev]

@autoantwort What about the android failing in the ci?

[autoantwort]

I think it is a baseline regression not caused by this PR.

[Osyotr]

It think that until microsoft/vcpkg-tool#813 is merged, default-features should not contain features that have supports expression.
Workaround is to create platform-default-features feature that has platform expression (https://github.com/microsoft/vcpkg/pull/31291/files#diff-fa5764c3245e6fdc2a5bd9ad48405b4e6f2555a4bff9079d365bb4990e3b002a)

[Cheney-W]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Cheney-W]

Pipeline issue came from #31155. I'm trying to fix it.

[talregev]

@Cheney-W
There already fix that approved
#29767

I will merge the master after you will merge it.

[dg0yt]

It think that until microsoft/vcpkg-tool#813 is merged, default-features should not contain features that have supports expression. Workaround is to create platform-default-features feature that has platform expression (https://github.com/microsoft/vcpkg/pull/31291/files#diff-fa5764c3245e6fdc2a5bd9ad48405b4e6f2555a4bff9079d365bb4990e3b002a)

This still must be done.

[Cheney-W]

I have converted your PR to draft status. When you respond to Victor's suggestion, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

[talregev]

@Cheney-W @vicroms
Ready for review.

stale