Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[baseline][gz-math7] Control options #31277

Merged
merged 1 commit into from
May 9, 2023
Merged

[baseline][gz-math7] Control options #31277

merged 1 commit into from
May 9, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented May 5, 2023 •
edited
Loading

Fixes baseline regression when pybind11 is installed before gz-math7.
Alternative to #31248, without patching. CC @LilyWangLL @Cheney-W

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt dg0yt mentioned this pull request May 5, 2023
Merged
7 tasks
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label May 6, 2023
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 6, 2023
@LilyWangLL LilyWangLL mentioned this pull request May 6, 2023
Closed
7 tasks
@dg0yt dg0yt mentioned this pull request May 7, 2023
Draft
@vicroms vicroms merged commit f1a37c0 into microsoft:master May 9, 2023
@dg0yt dg0yt deleted the gz-math branch May 9, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheney-W Cheney-W Cheney-W approved these changes

@JavierMatosD JavierMatosD JavierMatosD approved these changes

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dg0yt @Cheney-W @JavierMatosD @LilyWangLL @vicroms @FrankXie05