Skip to content

Conversation

@Cheney-W
Copy link
Contributor

Fixes vcpkg pipeline issue urho3d:x64-linux installation failed with following error:

CMake Error at Source/ThirdParty/SDL/cmake/sdlchecks.cmake:49 (get_filename_component):
  get_filename_component unknown component
  /mnt/vcpkg-ci/installed/x64-linux/lib/libasound.a

This issue only occurs when alsa:x64-linux is installed. The reason is that Urho3D executes the find_package (ALSA) command on Unix systems, which previously failed to find ALSA in previous CI tests.
However, since the PR #30960 is merged, it has found the installed ALSA provided by vcpkg, which triggers subsequent commands and causes the above error.

Because Urho3D's vcpkg.json contains the following content:

"$note": "Due to the upstream modification of the dependent source code, the internal port of vcpkg cannot be used."

and Urho3D needs dynamic ALSA, I added -DCMAKE_DISABLE_FIND_PACKAGE_ALSA=ON to fix this issue.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Apr 27, 2023
@Cheney-W Cheney-W marked this pull request as ready for review April 27, 2023 10:19
@BillyONeal BillyONeal merged commit 1877126 into microsoft:master Apr 27, 2023
@BillyONeal
Copy link
Member

Thanks for the fix!

BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Apr 28, 2023
* Entries at the end reordered to where they go.
* Entries starting with 'g' were scrambled.

Partially complete CI run results: https://dev.azure.com/vcpkg/public/_build/results?buildId=88831

PASSING, REMOVE FROM FAIL LIST: fbgemm:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: fontconfig:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: fontconfig:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: fontconfig:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: glib:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: glib:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: glib:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: joltphysics:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: joltphysics:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: joltphysics:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: libass:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: libass:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: libass:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: open62541:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: open62541:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: open62541:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).

I'm not going to bother figuring out specifically which commit fixed these because this is the first normal full CI run including Android, and it could be any amount of skew that happened while microsoft#29406 was in development.

REGRESSION: cairo:x64-android failed with BUILD_FAILED. If expected, add cairo:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: fltk:arm-neon-android failed with BUILD_FAILED. If expected, add fltk:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: fltk:arm64-android failed with BUILD_FAILED. If expected, add fltk:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: fltk:x64-android failed with BUILD_FAILED. If expected, add fltk:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: nana:arm-neon-android failed with BUILD_FAILED. If expected, add nana:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: nana:arm64-android failed with BUILD_FAILED. If expected, add nana:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: nana:x64-android failed with BUILD_FAILED. If expected, add nana:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.

Previously blocked by fontconfig.

REGRESSION: freerdp:x64-android failed with BUILD_FAILED. If expected, add freerdp:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gdk-pixbuf:arm-neon-android failed with BUILD_FAILED. If expected, add gdk-pixbuf:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gdk-pixbuf:arm64-android failed with BUILD_FAILED. If expected, add gdk-pixbuf:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gdk-pixbuf:x64-android failed with BUILD_FAILED. If expected, add gdk-pixbuf:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:arm-neon-android failed with BUILD_FAILED. If expected, add gstreamer:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:arm64-android failed with BUILD_FAILED. If expected, add gstreamer:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:x64-android failed with BUILD_FAILED. If expected, add gstreamer:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gts:arm-neon-android failed with BUILD_FAILED. If expected, add gts:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gts:arm64-android failed with BUILD_FAILED. If expected, add gts:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gts:x64-android failed with BUILD_FAILED. If expected, add gts:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: lcm:arm-neon-android failed with BUILD_FAILED. If expected, add lcm:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: lcm:arm64-android failed with BUILD_FAILED. If expected, add lcm:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: lcm:x64-android failed with BUILD_FAILED. If expected, add lcm:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: libgpod:arm-neon-android failed with BUILD_FAILED. If expected, add libgpod:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: libgpod:arm64-android failed with BUILD_FAILED. If expected, add libgpod:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: libgpod:x64-android failed with BUILD_FAILED. If expected, add libgpod:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: openscap:arm-neon-android failed with BUILD_FAILED. If expected, add openscap:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: openscap:arm64-android failed with BUILD_FAILED. If expected, add openscap:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: openscap:x64-android failed with BUILD_FAILED. If expected, add openscap:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.

Previously blocked by glib

REGRESSION: qt5-base:arm-neon-android failed with BUILD_FAILED. If expected, add qt5-base:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: qt5-base:arm64-android failed with BUILD_FAILED. If expected, add qt5-base:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: qt5-base:x64-android failed with BUILD_FAILED. If expected, add qt5-base:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.

In the PR that added Android to ci, qt5-base was a cascade because harfbuzz was a cascade: https://dev.azure.com/vcpkg/public/_build/results?buildId=88710 . Possible stealth merge conflict with microsoft#30852 which might have fixed harfbuzz?

REGRESSION: urho3d:x64-linux failed with BUILD_FAILED. If expected, add urho3d:x64-linux=fail to /agent/_work/1/s/scripts/azure-pipelines/../ci.baseline.txt.

Fixed by microsoft#31147
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 28, 2023
@Cheney-W Cheney-W deleted the Dev/Cheney/baseline branch April 28, 2023 02:07
BillyONeal added a commit that referenced this pull request Apr 28, 2023
* Also fixed ordering issues:

* Entries at the end reordered to where they go.
* Entries starting with 'g' were scrambled.

Partially complete CI run results: https://dev.azure.com/vcpkg/public/_build/results?buildId=88831

PASSING, REMOVE FROM FAIL LIST: fbgemm:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: fontconfig:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: fontconfig:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: fontconfig:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: glib:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: glib:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: glib:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: joltphysics:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: joltphysics:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: joltphysics:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: libass:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: libass:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: libass:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: open62541:arm-neon-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: open62541:arm64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: open62541:x64-android (/vcpkg/scripts/azure-pipelines/../ci.baseline.txt).

I'm not going to bother figuring out specifically which commit fixed these because this is the first normal full CI run including Android, and it could be any amount of skew that happened while #29406 was in development.

REGRESSION: cairo:x64-android failed with BUILD_FAILED. If expected, add cairo:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: fltk:arm-neon-android failed with BUILD_FAILED. If expected, add fltk:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: fltk:arm64-android failed with BUILD_FAILED. If expected, add fltk:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: fltk:x64-android failed with BUILD_FAILED. If expected, add fltk:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: nana:arm-neon-android failed with BUILD_FAILED. If expected, add nana:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: nana:arm64-android failed with BUILD_FAILED. If expected, add nana:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: nana:x64-android failed with BUILD_FAILED. If expected, add nana:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.

Previously blocked by fontconfig.

REGRESSION: freerdp:x64-android failed with BUILD_FAILED. If expected, add freerdp:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gdk-pixbuf:arm-neon-android failed with BUILD_FAILED. If expected, add gdk-pixbuf:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gdk-pixbuf:arm64-android failed with BUILD_FAILED. If expected, add gdk-pixbuf:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gdk-pixbuf:x64-android failed with BUILD_FAILED. If expected, add gdk-pixbuf:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:arm-neon-android failed with BUILD_FAILED. If expected, add gstreamer:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:arm64-android failed with BUILD_FAILED. If expected, add gstreamer:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:x64-android failed with BUILD_FAILED. If expected, add gstreamer:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gts:arm-neon-android failed with BUILD_FAILED. If expected, add gts:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gts:arm64-android failed with BUILD_FAILED. If expected, add gts:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: gts:x64-android failed with BUILD_FAILED. If expected, add gts:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: lcm:arm-neon-android failed with BUILD_FAILED. If expected, add lcm:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: lcm:arm64-android failed with BUILD_FAILED. If expected, add lcm:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: lcm:x64-android failed with BUILD_FAILED. If expected, add lcm:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: libgpod:arm-neon-android failed with BUILD_FAILED. If expected, add libgpod:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: libgpod:arm64-android failed with BUILD_FAILED. If expected, add libgpod:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: libgpod:x64-android failed with BUILD_FAILED. If expected, add libgpod:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: openscap:arm-neon-android failed with BUILD_FAILED. If expected, add openscap:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: openscap:arm64-android failed with BUILD_FAILED. If expected, add openscap:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: openscap:x64-android failed with BUILD_FAILED. If expected, add openscap:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.

Previously blocked by glib

REGRESSION: qt5-base:arm-neon-android failed with BUILD_FAILED. If expected, add qt5-base:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: qt5-base:arm64-android failed with BUILD_FAILED. If expected, add qt5-base:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: qt5-base:x64-android failed with BUILD_FAILED. If expected, add qt5-base:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.

In the PR that added Android to ci, qt5-base was a cascade because harfbuzz was a cascade: https://dev.azure.com/vcpkg/public/_build/results?buildId=88710 . Possible stealth merge conflict with #30852 which might have fixed harfbuzz?

REGRESSION: urho3d:x64-linux failed with BUILD_FAILED. If expected, add urho3d:x64-linux=fail to /agent/_work/1/s/scripts/azure-pipelines/../ci.baseline.txt.

Fixed by #31147

* Also fix zeroc-ice order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants