Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stackwalker] add new port #30909

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Conversation

AenBleidd
Copy link
Contributor

If this PR adds a new port, please uncomment and fill out this checklist:

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 17, 2023
Signed-off-by: Vitalii Koshura <[email protected]>
@AenBleidd AenBleidd force-pushed the vko_add_stackwalker branch from 35f4b79 to f78a99d Compare April 17, 2023 09:56
@AenBleidd AenBleidd requested a review from FrankXie05 April 17, 2023 09:56
@AenBleidd
Copy link
Contributor Author

@FrankXie05, please review

@FrankXie05
Copy link
Contributor

The usage has been tested successfully locally.

FrankXie05
FrankXie05 previously approved these changes Apr 20, 2023
@FrankXie05 FrankXie05 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 20, 2023
@BillyONeal BillyONeal merged commit 95252ea into microsoft:master Apr 21, 2023
@BillyONeal
Copy link
Member

Thanks for the new port! Here's hoping upstream drops a release soon!

@AenBleidd AenBleidd deleted the vko_add_stackwalker branch April 21, 2023 00:25
@AenBleidd
Copy link
Contributor Author

Here's hoping upstream drops a release soon!

Me as well :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants