-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[makeid] Add new port #30902
[makeid] Add new port #30902
Conversation
Co-authored-by: Mengna Li <[email protected]>
Co-authored-by: Mengna Li <[email protected]>
ports/makeid/portfile.cmake
Outdated
@@ -0,0 +1,17 @@ | |||
vcpkg_download_distfile(ARCHIVE | |||
URLS "http://www.humus.name/3D/MakeID.h" | |||
FILENAME "MakeID.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There can't be different versions (and SHA512) with the same name.
Can we use FILENNAME "MakeID.h-${VERSION}"
here (and in the copy command below)?
I'm a bit concerned over 'makeid' since that seems likely to be a conflicting name but I can't find any actual conflicts so I guess this works. If you know how to contract upstream it would be good to ask them to make versioned download locations. |
In that case we should quickly move it to a subdir... |
I didn't find any actual conflicts so I don't think it needs a subdir. Unless we see actual conflicts. |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.