Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeid] Add new port #30902

Merged
merged 8 commits into from
Apr 17, 2023
Merged

[makeid] Add new port #30902

merged 8 commits into from
Apr 17, 2023

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Apr 16, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@Adela0814 Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 17, 2023
ports/makeid/portfile.cmake Outdated Show resolved Hide resolved
ports/makeid/portfile.cmake Outdated Show resolved Hide resolved
@Adela0814 Adela0814 changed the title [MakeID] Add new port [makeid] Add new port Apr 17, 2023
Adela0814
Adela0814 previously approved these changes Apr 17, 2023
@@ -0,0 +1,17 @@
vcpkg_download_distfile(ARCHIVE
URLS "http://www.humus.name/3D/MakeID.h"
FILENAME "MakeID.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There can't be different versions (and SHA512) with the same name.
Can we use FILENNAME "MakeID.h-${VERSION}" here (and in the copy command below)?

@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Apr 17, 2023
@BillyONeal
Copy link
Member

I'm a bit concerned over 'makeid' since that seems likely to be a conflicting name but I can't find any actual conflicts so I guess this works.

If you know how to contract upstream it would be good to ask them to make versioned download locations.

@BillyONeal BillyONeal merged commit ce69d61 into microsoft:master Apr 17, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Apr 18, 2023

I'm a bit concerned over 'makeid' since that seems likely to be a conflicting name.

In that case we should quickly move it to a subdir...

@BillyONeal
Copy link
Member

I'm a bit concerned over 'makeid' since that seems likely to be a conflicting name.

In that case we should quickly move it to a subdir...

I didn't find any actual conflicts so I don't think it needs a subdir. Unless we see actual conflicts.

@Pospelove Pospelove deleted the makeid branch April 18, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants