-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[omniorb] new port #30900
[omniorb] new port #30900
Conversation
"version": "4.3.0", | ||
"description": "omniORB is a robust high performance CORBA ORB for C++", | ||
"license": "LGPL-2.1-or-later", | ||
"supports": "!uwp & !((arm | x86) & windows) & !osx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the windows stuff is manily due to what vcpkg_configure_make considers cross compiling. It probably could be patched to make it work but I am not going to spend time on that.
@JonLiu1993 Why did you add |
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
No usage needs to be tested:
|
fix_dependency.patch | ||
def_gen_fix.patch | ||
msvc-src-build-fixes.patch | ||
release-debug-static.patch | ||
add_win_into_autotools.patch | ||
python-fixes.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have these been submitted upstream? They might not care about Windows so much but clearly the unedited code is talking about dumpbin and winver so they must care somewhat.
set(progs C_COMPILER CXX_COMPILER AR | ||
LINKER RANLIB OBJDUMP MT | ||
STRIP NM DLLTOOL RC_COMPILER) | ||
list(TRANSFORM progs PREPEND "VCPKG_DETECTED_CMAKE_") | ||
foreach(prog IN LISTS progs) | ||
if(${prog}) | ||
set(path "${${prog}}") | ||
unset(prog_found CACHE) | ||
get_filename_component(${prog} "${${prog}}" NAME) | ||
find_program(prog_found ${${prog}} PATHS ENV PATH NO_DEFAULT_PATH) | ||
if(NOT path STREQUAL prog_found) | ||
get_filename_component(path "${path}" DIRECTORY) | ||
vcpkg_add_to_path(PREPEND ${path}) | ||
endif() | ||
endif() | ||
endforeach() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block looks like it is likely to happen elsewhere. Do you think it's worth extracting for other ports to use? If not, no change requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is actually copied out of vcpkg_configure_make
. So if that ever gets updated it can be refactored out there.
Thanks for the new port! |
Thanks again! |
@BillyONeal please remove the tag(info:new-port-unresolved) from #3346 |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says.The generated "usage text" is accurate. See adding-usage for context../vcpkg x-add-version --all
and committing the result.(i feel like deleting the above if I put in x everywhere anyway)
supersedes #7071; #8609
removes tag from #3346