[libzim]add package

[xiaoyifang]

If this PR adds a new port, please uncomment and fill out this checklist:

• Changes comply with the maintainer guide
• The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
• Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
• The versioning scheme in vcpkg.json matches what upstream says.
• The license declaration in vcpkg.json matches what upstream says.
• The installed as the "copyright" file matches what upstream says.
• The source code of the component installed comes from an authoritative source.
• The generated "usage text" is accurate. See adding-usage for context.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is in the new port's versions file.
• Only one version is added to each modified port's versions file.

[Adela0814]

Is work still being done for this PR? Please ping us if this PR is ready for review.

[xiaoyifang]

should hold for a while as libzim's windows release has some problem.

[xiaoyifang]

I can build success on my local machine .
I do not know why it failed here. need some help.

[xiaoyifang]

vcpkg seems have encounter some build issue problem. the check task has not been finished in hours.

[Adela0814]

@xiaoyifang Feature xapian test failed:
Repro step: vcpkg install libzim[xapian]:x64-windows
FAILED: src/zim-8.dll.p/version.cpp.obj "C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.34.31933/bin/Hostx64/x64/cl.exe" "-Isrc\zim-8.dll.p" "-Isrc" "-I..\src\8.2.0-10b574337e.clean\src" "-Iinclude" "-I..\src\8.2.0-10b574337e.clean\include" "-Istatic" "-IE:/2/vcpkg/installed/x64-windows/debug/../include" "-IE:/2/vcpkg/installed/x64-windows/include" "/MDd" "/nologo" "/showIncludes" "/utf-8" "/W2" "/EHsc" "/std:c++14" "/permissive-" "/Od" "-DNOMINMAX" "-nologo" "-DWIN32" "-D_WINDOWS" "-W3" "-utf-8" "-GR" "-EHsc" "-MP" "-D_DEBUG" "-MDd" "-Z7" "-Ob0" "-Od" "-RTC1" "-DSORTPP_PASS" "-DLIBZIM_EXPORT_DLL" "/Fdsrc\zim-8.dll.p\version.cpp.pdb" /Fosrc/zim-8.dll.p/version.cpp.obj "/c" ../src/8.2.0-10b574337e.clean/src/version.cpp cl : Command line warning D9025 : overriding '/W2' with '/W3' E:\2\vcpkg\installed\x64-windows\include\xapian/version.h(25): fatal error C1189: #error: You are compiling with _DEBUG defined, but the library
package-x64-windows-dbg-out.log

[xiaoyifang]

@xiaoyifang Feature xapian test failed: Repro step: vcpkg install libzim[xapian]:x64-windows FAILED: src/zim-8.dll.p/version.cpp.obj "C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.34.31933/bin/Hostx64/x64/cl.exe" "-Isrc\zim-8.dll.p" "-Isrc" "-I..\src\8.2.0-10b574337e.clean\src" "-Iinclude" "-I..\src\8.2.0-10b574337e.clean\include" "-Istatic" "-IE:/2/vcpkg/installed/x64-windows/debug/../include" "-IE:/2/vcpkg/installed/x64-windows/include" "/MDd" "/nologo" "/showIncludes" "/utf-8" "/W2" "/EHsc" "/std:c++14" "/permissive-" "/Od" "-DNOMINMAX" "-nologo" "-DWIN32" "-D_WINDOWS" "-W3" "-utf-8" "-GR" "-EHsc" "-MP" "-D_DEBUG" "-MDd" "-Z7" "-Ob0" "-Od" "-RTC1" "-DSORTPP_PASS" "-DLIBZIM_EXPORT_DLL" "/Fdsrc\zim-8.dll.p\version.cpp.pdb" /Fosrc/zim-8.dll.p/version.cpp.obj "/c" ../src/8.2.0-10b574337e.clean/src/version.cpp cl : Command line warning D9025 : overriding '/W2' with '/W3' E:\2\vcpkg\installed\x64-windows\include\xapian/version.h(25): fatal error C1189: #error: You are compiling with _DEBUG defined, but the library package-x64-windows-dbg-out.log

xapian only support release library. How can I disable debug library?
if I add the following line,
set(VCPKG_BUILD_TYPE release)?

the check will not pass with error

Debug binaries were not found.
Found 1 release binaries:

    D:\packages\libzim_arm64-windows\lib\zim.lib

warning: Mismatching number of debug and release binaries.
Debug binaries were not found.
Found 1 release binaries:

    D:\packages\libzim_arm64-windows\bin\zim-8.dll

error: Found 2 post-build check problem(s). 

[dg0yt]

xapian only support release library.

I don't think this is right. vcpkg builds both configurations.
However, vcpkg only keeps the release variant of the includes. In most cases it is no problem, but if the headers contain information about the build type, there will be trouble. This needs fixup in port xapian.

There is currently no other port which consumes xapian, and the problem might be specific to MSVC. I guess that's why it wasn't noticed before.
Instead of disabling debug (for all possible feature sets), try marking feature xapian as unsupported on window & !mingw. Fixing can be done in a separate PR.
("Unsupported" is not really true with regard to upstream, but IMO it is still the cleanest solution in vcpkg for now.)

[xiaoyifang]

However, vcpkg only keeps the release variant of the includes. In most cases it is no problem, but if the headers contain information about the build type, there will be trouble. This needs fixup in port xapian.

This is in the xapian.h

#ifdef _MSC_VER
#ifdef _DEBUG
#error You are compiling with _DEBUG defined, but the library
#error was not compiled with this flag. The settings must match or your
#error program will not work correctly.
#endif
#endif

[xiaoyifang]

Build log #L22298
REGRESSIONS:
REGRESSION: libass:x64-android failed with BUILD_FAILED. If expected, add libass:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: azure-c-shared-utility:x64-android failed with BUILD_FAILED. If expected, add azure-c-shared-utility:x64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt.
REGRESSION: libressl:x64-android failed with POST_BUILD_CHECKS_FAILED. If expected, add libressl:x64-android=fail to /vcpkg/scripts/azure-pipelines/..

weird , I do not think I changed libass?

I think I need to disable android support for now.

[dg0yt]

This is in the xapian.h

Yes, this was the base for my comment. It might even be possible to remove that code, but it needs more investigation. This doesn't need to be done in this PR.

Build log #L22298
...
weird , I do not think I changed libass?

Cannot check the logs because you didn't let that CI run finish.

[xiaoyifang]

Yes, this was the base for my comment. It might even be possible to remove that code, but it needs more investigation. This doesn't need to be done in this PR.

#31338

comments resolved