Skip to content

Conversation

@FabienPean
Copy link
Contributor

@FabienPean FabienPean commented Apr 2, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

See the discussion here: #27963 (comment)

Pasting the reply again here for completeness:

There is clearly something happening here that is not just copying headers. Things like LIBIGL_USE_STATIC_LIBRARY suggest that there is in fact a static library and that this thing is not header only. Can you explain why / how this is header only despite the port clearly doing not header only things?

With this option, the library is explicitly instantiating some templates into a static library, but, it also removes all definition of the templated functions... Building with LIBIGL_USE_STATIC_LIBRARY is fundamentally different from standard expectation when considering static/shared. It was the case then #14888, it is still applicable now after checking the repo.

Ultimately this means using libigl after this PR with a static vcpkg triplet would break users relying on types outside the ones allowed by libigl devs.

@BillyONeal @FrankXie05

@FabienPean
Copy link
Contributor Author

More problems with v2.4.0, please follow the related issue #30621

@FabienPean FabienPean marked this pull request as ready for review April 2, 2023 19:49
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Apr 3, 2023
@vicroms vicroms merged commit dd28469 into microsoft:master Apr 5, 2023
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants