Skip to content

Conversation

@carsten-grimm-at-ipolog
Copy link
Contributor

@carsten-grimm-at-ipolog carsten-grimm-at-ipolog commented Apr 2, 2023

Fixes #30006.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download (no downloads were updated)
  • The "supports" clause reflects platforms that may be fixed by this new version (not applicable)
  • Any fixed CI baseline entries are removed from that file. (no changes were made to that file).
  • Any patches that are no longer applied are deleted from the port's directory. (build_3.patch has been removed)
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Details:

  • As described in Issue [qt5-webengine] Build error #30006, posted by @jrosener, building qt5-webengine on windows with newer version of msvc fail. This is because newer versions of msvc require includes that previous versions did not require.
  • This pull request adds two missing includes to third party libraries that are used by qt5-webengine:
    • chromium with an include for string in src/3rdparty/chromium/ui/accessibility/ax_table_info.h
    • libxml with an include for stdbool.h in src/3rdparty/chromium/third_party/libxml/src/encoding.c

Thanks to @marco-langer for the assistance with the patch for libxml.

This fixes issue microsoft#30006. Newer versions of msvc require more includes than previous versions. To accommodate this change, two missing includes are added to the third party libraries chromium and libxml.
@carsten-grimm-at-ipolog
Copy link
Contributor Author

carsten-grimm-at-ipolog commented Apr 2, 2023 via email

@carsten-grimm-at-ipolog carsten-grimm-at-ipolog marked this pull request as ready for review April 2, 2023 13:51
@Cheney-W Cheney-W added the category:port-bug The issue is with a library, which is something the port should already support label Apr 3, 2023
@Adela0814 Adela0814 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Apr 6, 2023
@vicroms vicroms merged commit 668bf87 into microsoft:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[qt5-webengine] Build error

5 participants