Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HiGHS] Added new port for the HiGHS optimization library #30529

Merged
merged 24 commits into from
Apr 3, 2023

Conversation

mathgeekcoder
Copy link
Contributor

@mathgeekcoder mathgeekcoder commented Mar 29, 2023

Fixes #30527

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@mathgeekcoder mathgeekcoder marked this pull request as ready for review March 29, 2023 21:10
@JonLiu1993 JonLiu1993 changed the title Added new port for the HiGHS optimization library [HiGHS] Added new port for the HiGHS optimization library Mar 30, 2023
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 30, 2023
JonLiu1993
JonLiu1993 previously approved these changes Mar 31, 2023
@JonLiu1993
Copy link
Member

Tested usage by highs:x64-windows successfully:

The package highs is compatible with built-in CMake targets:

    find_package(highs REQUIRED)
    target_link_libraries(main PRIVATE highs::highs)

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 31, 2023
@mathgeekcoder
Copy link
Contributor Author

mathgeekcoder commented Mar 31, 2023

Sorry, I clicked 'close' thinking it should merge. Rookie mistake.

ports/highs/fix-threads.patch Outdated Show resolved Hide resolved
ports/highs/portfile.cmake Outdated Show resolved Hide resolved
ports/highs/vcpkg.json Outdated Show resolved Hide resolved
@mathgeekcoder mathgeekcoder requested a review from dg0yt April 1, 2023 22:06
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port looks good now, but I do have some more comments.

ports/highs/fix-threads.patch Outdated Show resolved Hide resolved
ports/highs/fix-pkgconfig-path.patch Outdated Show resolved Hide resolved
ports/highs/portfile.cmake Outdated Show resolved Hide resolved
ports/highs/portfile.cmake Outdated Show resolved Hide resolved
@mathgeekcoder mathgeekcoder requested a review from dg0yt April 2, 2023 23:32
@vicroms vicroms merged commit a8e1b59 into microsoft:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] highs
4 participants