Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msgpack-c] Added msgpack-c version 6.0.0 #30389

Merged
merged 2 commits into from
Mar 25, 2023
Merged

Conversation

Sharpe49
Copy link
Contributor

@Sharpe49 Sharpe49 commented Mar 23, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Sorry, something went wrong.

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 24, 2023
@FrankXie05
Copy link
Contributor

FrankXie05 commented Mar 24, 2023

@Sharpe49
Thank you for pointing out the problem. I did ignore the problem with C and C++ libraries on different branches.

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Mar 24, 2023
@vicroms vicroms merged commit 11552ac into microsoft:master Mar 25, 2023
@Sharpe49 Sharpe49 deleted the msgpackc branch March 25, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants