Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libtar] new port #30317

Merged
merged 2 commits into from
Mar 23, 2023
Merged

[libtar] new port #30317

merged 2 commits into from
Mar 23, 2023

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Mar 20, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@talregev talregev changed the title [librar] new port [libtar] new port Mar 20, 2023
@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 21, 2023
FrankXie05
FrankXie05 requested changes Mar 21, 2023
View reviewed changes
ports/libtar/portfile.cmake Outdated Show resolved Hide resolved
@talregev talregev requested a review from FrankXie05 March 21, 2023 09:06
FrankXie05
FrankXie05 previously approved these changes Mar 21, 2023
View reviewed changes
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Mar 21, 2023
@talregev
Copy link
Contributor Author

@FrankXie05 Can you tell what happen to the ci?

@talregev talregev requested a review from FrankXie05 March 21, 2023 20:31
@talregev talregev requested review from vicroms and removed request for FrankXie05 March 21, 2023 21:15
@talregev
Copy link
Contributor Author

@vicroms
I add set(VCPKG_USE_HEAD_VERSION ON) because it fail to fetch it with REF var.
I restore the line as before.

@dg0yt
Copy link
Contributor

dg0yt commented Mar 22, 2023

Can you at least try REF 50dcdd27a33444b974d940ed5f225a2444e5aeba (which is v1.2.20)?
This repo hasn't been updated in 9 years...

@FrankXie05
Copy link
Contributor

See https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/maintainers/functions/vcpkg_from_git.md?plain=1#:~:text=vcpkg_from_git(,)

@talregev
Copy link
Contributor Author

Can you at least try REF 50dcdd27a33444b974d940ed5f225a2444e5aeba (which is v1.2.20)? This repo hasn't been updated in 9 years...

Yes, I guess I will do it. I prefer it with version.

@talregev
Copy link
Contributor Author

@vicroms @FrankXie05
Ready for review.

@talregev talregev requested review from FrankXie05 and removed request for vicroms March 22, 2023 06:40
@talregev
Copy link
Contributor Author

talregev commented Mar 22, 2023 •
edited
Loading

@FrankXie05 Please take a look. Please don't let me wait for simple thing. I already change and remove that line.

@talregev
Copy link
Contributor Author

@FrankXie05 Please remove the label author-response

FrankXie05
FrankXie05 previously approved these changes Mar 23, 2023
View reviewed changes
@FrankXie05
Copy link
Contributor

Sorry about that. :)

vicroms
vicroms requested changes Mar 23, 2023
View reviewed changes
ports/libtar/portfile.cmake Outdated Show resolved Hide resolved
@talregev talregev requested review from FrankXie05 and vicroms and removed request for FrankXie05 and vicroms March 23, 2023 19:30
@talregev
Copy link
Contributor Author

@FrankXie05 @vicroms Can you review again?

@vicroms vicroms merged commit 5736083 into microsoft:master Mar 23, 2023
@talregev talregev deleted the TalR/libtar branch March 23, 2023 23:02
@dg0yt
Copy link
Contributor

dg0yt commented Mar 23, 2023

(you can keep the version number the same).

I repeat: Bad practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@vicroms vicroms vicroms approved these changes

@FrankXie05 FrankXie05 Awaiting requested review from FrankXie05

Assignees

@FrankXie05 FrankXie05

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@talregev @dg0yt @FrankXie05 @vicroms