Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[argparse] bump version to 2.9 #30206

Merged
merged 2 commits into from
Mar 20, 2023
Merged

[argparse] bump version to 2.9 #30206

merged 2 commits into from
Mar 20, 2023

Conversation

marcovc
Copy link
Contributor

@marcovc marcovc commented Mar 15, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@marcovc marcovc closed this Mar 15, 2023
@marcovc marcovc reopened this Mar 15, 2023
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Mar 16, 2023
@MonicaLiu0311
Copy link
Contributor

Looks like the EOL of portfile.cmake is changed.

@marcovc
Copy link
Contributor Author

marcovc commented Mar 16, 2023

Sorry what do you mean by EOL?

@MonicaLiu0311
Copy link
Contributor

Sorry what do you mean by EOL?

End of line.
image

@marcovc
Copy link
Contributor Author

marcovc commented Mar 16, 2023

I guess the initial file was submitted in a windows OS and now I am on a mac. Is this a problem?

@MonicaLiu0311
Copy link
Contributor

This file originally ended with CRLF, but now it ends with LF, which will generate unnecessary modification records, just like the current performance of portfile.cmake.

image

Many editors can modify EOF, just submit it after modification.

@MonicaLiu0311 MonicaLiu0311 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 17, 2023
@dan-shaw dan-shaw merged commit 447033e into microsoft:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcovc @MonicaLiu0311 @dan-shaw