Skip to content

Conversation

@autoantwort
Copy link
Contributor

Fixes #29371 (comment).
Now the following is emitted:

nifticlib provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(NIFTI CONFIG REQUIRED)
    target_link_libraries(main PRIVATE NIFTI::znz NIFTI::niftiio)

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Mar 13, 2023
@MonicaLiu0311
Copy link
Contributor

Fixes #29371 (comment). Now the following is emitted:

nifticlib provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(NIFTI CONFIG REQUIRED)
    target_link_libraries(main PRIVATE NIFTI::znz NIFTI::niftiio)

After using your modification, the generated usage is as follows, which is slightly different from the usage you mentioned above, but both usages pass the test (the header file is found):

nifticlib provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(NIFTI CONFIG REQUIRED)
    target_link_libraries(main PRIVATE NIFTI::znz NIFTI::nifti2 NIFTI::niftiio NIFTI::nifticdf)

@autoantwort
Copy link
Contributor Author

@MonicaLiu0311 Why is this marked https://github.com/microsoft/vcpkg/labels/requires%3Aauthor-response? You have installed a different set of features and therefore get a different usage text. This is expected behaviour.

@MonicaLiu0311 MonicaLiu0311 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 14, 2023
@dan-shaw dan-shaw merged commit 090b767 into microsoft:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants