Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backward-cpp] new port #30101

Merged
merged 6 commits into from
Mar 30, 2023
Merged

[backward-cpp] new port #30101

merged 6 commits into from
Mar 30, 2023

Conversation

fran6co
Copy link
Contributor

@fran6co fran6co commented Mar 9, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jimwang118 jimwang118 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 9, 2023
Co-authored-by: jim wang <122244446+jimwang118@users.noreply.github.com>
@jimwang118
Copy link
Contributor

You should use the .\vcpkg.exe x-add-version {port name} --overwrite-version command to re-update the port's git-tree.

@fran6co
Copy link
Contributor Author

fran6co commented Mar 28, 2023

@jimwang118 done

jimwang118
jimwang118 previously approved these changes Mar 29, 2023
@jimwang118
Copy link
Contributor

The usage has been tested successfully locally. 

find_package(Backward CONFIG REQUIRED)
target_link_libraries(main PRIVATE Backward::Backward)

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Mar 30, 2023
@vicroms vicroms merged commit 4ee9010 into microsoft:master Mar 30, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Apr 5, 2023

The usage has been tested successfully locally.

... at cmake configuration time, but not for an actual build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants