Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP toolchain fix and update some supports expressions for uwp/xbox #30096

Merged
merged 10 commits into from
Mar 20, 2023

Conversation

walbourn
Copy link
Member

@walbourn walbourn commented Mar 9, 2023

While working on the xbox triplets, we found a bug in the uwp toolchain treatment of the cross compiling variable. This fixes the uwp toolchain file.

In addition, updated a few ports supports expression to block them for uwp and/or xbox.

@Adela0814 Adela0814 self-assigned this Mar 9, 2023
@Adela0814 Adela0814 added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Mar 9, 2023
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Mar 13, 2023
@dan-shaw dan-shaw added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Mar 15, 2023
@dan-shaw
Copy link
Contributor

Can you elaborate on what was the bug you found in the uwp toolchain?

@dan-shaw dan-shaw added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Mar 17, 2023
@walbourn
Copy link
Member Author

Can you elaborate on what was the bug you found in the uwp toolchain?

Adding @BillyONeal who helped me verify the issue.

Targeting UWP is 'cross-compiling' whether you are building on a Windows host, a macOS host, or a Linux host. The older logic only considered it 'cross-compiling' while on a Windows host.

@dan-shaw dan-shaw added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 20, 2023
@vicroms vicroms merged commit 7a4ca3f into microsoft:master Mar 20, 2023
@walbourn walbourn deleted the uwpfixes branch April 5, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants