-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UWP toolchain fix and update some supports expressions for uwp/xbox #30096
Merged
+99
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neumann-A
reviewed
Mar 9, 2023
walbourn
commented
Mar 9, 2023
Adela0814
approved these changes
Mar 13, 2023
Can you elaborate on what was the bug you found in the uwp toolchain? |
Adding @BillyONeal who helped me verify the issue. Targeting UWP is 'cross-compiling' whether you are building on a Windows host, a macOS host, or a Linux host. The older logic only considered it 'cross-compiling' while on a Windows host. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:community-triplet
A PR or issue related to community triplets not officially validated by the vcpkg team.
info:reviewed
Pull Request changes follow basic guidelines
requires:vcpkg-team-review
This PR or issue requires someone on the vcpkg team to take a further look.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the xbox triplets, we found a bug in the uwp toolchain treatment of the cross compiling variable. This fixes the uwp toolchain file.
In addition, updated a few ports supports expression to block them for uwp and/or xbox.