Skip to content

[qt5-base] Move 'icu' out of 'core' feature #30091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dan-shaw merged 1 commit into from
Mar 9, 2023
Merged

[qt5-base] Move 'icu' out of 'core' feature #30091

dan-shaw merged 1 commit into from
Mar 9, 2023

Conversation

@Osyotr
Copy link
Contributor

@Osyotr Osyotr commented Mar 8, 2023 •
edited
Loading

Extracted changes related to icu from #23668 cc. @dg0yt

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Osyotr
Osyotr commented Mar 8, 2023
View reviewed changes
@JonLiu1993 JonLiu1993 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Mar 9, 2023
dg0yt
dg0yt approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@JonLiu1993
Copy link
Contributor

JonLiu1993 commented Mar 9, 2023

Feature icu tested successfully by the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 9, 2023
@dan-shaw dan-shaw merged commit 78b1d6a into microsoft:master Mar 9, 2023
@Osyotr Osyotr deleted the qt5-icu branch March 9, 2023 20:35
@Osyotr Osyotr mentioned this pull request Mar 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@dg0yt dg0yt dg0yt approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JonLiu1993 JonLiu1993

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Osyotr @JonLiu1993 @dg0yt @Neumann-A @dan-shaw