Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x86-simd-sort] Add new port #30017

Merged
merged 8 commits into from
Mar 7, 2023

Conversation

chausner
Copy link
Contributor

@chausner chausner commented Mar 4, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@dg0yt dg0yt mentioned this pull request Mar 4, 2023
11 tasks
@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 6, 2023
@MonicaLiu0311
Copy link
Contributor

The usage test passed (header files found):

x86-simd-sort is header-only and can be used from CMake via:

    find_path(X86_SIMD_SORT_INCLUDE_DIRS "avx512-16bit-qsort.hpp")
    target_include_directories(main PRIVATE ${X86_SIMD_SORT_INCLUDE_DIRS})

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Mar 6, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Mar 6, 2023

find_path(X86_SIMD_SORT_INCLUDE_DIRS "avx512-16bit-qsort.hpp")

Is there a more generic / stable header name which could be used in an explicit usage file instead?

@MonicaLiu0311 MonicaLiu0311 removed the info:reviewed Pull Request changes follow basic guidelines label Mar 6, 2023
@chausner
Copy link
Contributor Author

chausner commented Mar 6, 2023 via email

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Mar 7, 2023
@dan-shaw dan-shaw merged commit 8421fa9 into microsoft:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants