-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hnswlib] new port #29848
[hnswlib] new port #29848
Conversation
Is this port head-only? If so, only the usage of |
@jimwang118 Yes it is header only, I removed the unofficial CMake target. Maybe as follow up question for the next port: If I have a header only library, but depending on this one, should I also only use find_path() and tell in the usage file, that the user must do and additional find_path for the dependency of the library, or would it in that case be ok to add an unofficial CMake target to manage dependencies automatically? |
Unofficial config should normally be avoided because it comes with a lock-in effect for users and for vcpkg. But there are situations where it can be useful enough even for header-only ports. |
Tested usage successfully by the hnswlib:x64-windows triplet. |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.