Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hnswlib] new port #29848

Merged
merged 3 commits into from
Mar 3, 2023
Merged

[hnswlib] new port #29848

merged 3 commits into from
Mar 3, 2023

Conversation

moritz-h
Copy link
Contributor

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@jimwang118 jimwang118 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 27, 2023
@jimwang118
Copy link
Contributor

Is this port head-only? If so, only the usage of find_path() is reserved in usage.

@moritz-h
Copy link
Contributor Author

@jimwang118 Yes it is header only, I removed the unofficial CMake target.

Maybe as follow up question for the next port: If I have a header only library, but depending on this one, should I also only use find_path() and tell in the usage file, that the user must do and additional find_path for the dependency of the library, or would it in that case be ok to add an unofficial CMake target to manage dependencies automatically?

@dg0yt
Copy link
Contributor

dg0yt commented Feb 28, 2023

Unofficial config should normally be avoided because it comes with a lock-in effect for users and for vcpkg. But there are situations where it can be useful enough even for header-only ports.

@jimwang118
Copy link
Contributor

Tested usage successfully by the hnswlib:x64-windows triplet.

@jimwang118 jimwang118 requested a review from JonLiu1993 March 1, 2023 02:50
@jimwang118 jimwang118 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 3, 2023
@dan-shaw dan-shaw merged commit 39f3c5c into microsoft:master Mar 3, 2023
@moritz-h moritz-h deleted the hnswlib branch March 3, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants