Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scope-guard] Add new port #29821

Merged
merged 5 commits into from
Feb 28, 2023
Merged

[scope-guard] Add new port #29821

merged 5 commits into from
Feb 28, 2023

Conversation

oold
Copy link

@oold oold commented Feb 24, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@oold oold marked this pull request as ready for review February 24, 2023 00:12
@FrankXie05 FrankXie05 self-assigned this Feb 24, 2023
@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 24, 2023
ports/scope-guard/portfile.cmake Show resolved Hide resolved
ports/scope-guard/portfile.cmake Outdated Show resolved Hide resolved
ports/scope-guard/portfile.cmake Outdated Show resolved Hide resolved
ports/scope-guard/vcpkg.json Show resolved Hide resolved
@oold oold requested a review from FrankXie05 February 24, 2023 21:50
@FrankXie05
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Feb 28, 2023
@JavierMatosD JavierMatosD merged commit 5aa33f1 into microsoft:master Feb 28, 2023
@oold oold deleted the scope_guard branch March 19, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants