-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Daxa] new port #29800
[Daxa] new port #29800
Conversation
E:\daxa\buildtrees\daxa\config-x86-windows-out.log:
config-x86-windows-out.log |
Co-authored-by: MonicaLiu <[email protected]>
If we don't want to support x86, osx, or arm, is there something I need to do? |
Please add "supports" in vcpkg.json. |
There is a CI error, please run this command to update git-tree:
|
thank you for the assistance, I think I got those things in now! |
Do I need to do more? |
All features are tested successfully in the following triplet: |
The usage test passed (header files found).
|
Could you please fix some deprecated functions? grateful. See portfile.cmake for details. |
"name": "vcpkg-cmake-config", | ||
"host": true | ||
}, | ||
"vulkan", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This port seems to have a dependency on x11
and Wayland
guarded by CMAKE_SYSTEM_NAME
https://github.com/Ipotrick/Daxa/blob/master/CMakeLists.txt#L163
x11
requires special consideration because, currently, it is assumed to be retrieved from the system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JavierMatosD I'm not exactly sure what needs to be done about this on my end. Could you clarify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Javier Matos Denizac <[email protected]>
d746f50
Am I meant to do something? I responded to a review and never got a response |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.