[arsenalgear] Add new port #29753
Merged
[arsenalgear] Add new port #29753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Frank <[email protected]>
Co-authored-by: Frank <[email protected]>
Co-authored-by: Frank <[email protected]>
Ok, please complete the modification of other review so that other codes meet the format requirements of vcpkg. After the modification is completed, this PR can be merged. |
|
Hi @jimwang118 , I already applied corrections from @FrankXie05 review. Do i need to do something else? I think he should maybe mark them as solved? |
|
Hello @jimwang118 and @FrankXie05 , Any news about this? |
jimwang118
requested changes
Mar 1, 2023
Co-authored-by: jim wang <[email protected]>
Co-authored-by: jim wang <[email protected]>
jimwang118
previously approved these changes
Mar 1, 2023
jimwang118
added
info:reviewed
dan-shaw
reviewed
Mar 2, 2023
dan-shaw
added
requires:author-response
and removed
info:reviewed
jimwang118
requested changes
Mar 3, 2023
Co-authored-by: jim wang <[email protected]>
jimwang118
requested changes
Mar 3, 2023
jimwang118
requested changes
Mar 3, 2023
Co-authored-by: jim wang <[email protected]>
jimwang118
approved these changes
Mar 3, 2023
FrankXie05
approved these changes
Mar 3, 2023
|
Tested usage successfully by the arsenalgear:x64-windows triplet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
This PR adds port to arsenalgear-cpp.
Which triplets are supported/not supported? Have you updated the CI baseline?
Linux, MacOS, Windows (no MSVC). Yes.
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes