Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miniaudio] Add new port #29740

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Conversation

kachkov98
Copy link
Contributor

This PR adds a port for miniaudio (header-only library): https://github.com/mackron/miniaudio

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context. (Usage text was not added explicitly, but it's still accurate)
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Port was tested on Linux machine with GCC 12.1.1 in manifest mode, everything works as expected.

@jimwang118 jimwang118 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 20, 2023
ports/miniaudio/portfile.cmake Show resolved Hide resolved
ports/miniaudio/portfile.cmake Outdated Show resolved Hide resolved
@jimwang118
Copy link
Contributor

Tested usage successfully by the miniaudio:x64-windows triplet.

@jimwang118 jimwang118 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 22, 2023
@JavierMatosD JavierMatosD merged commit 4149a22 into microsoft:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants