Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uni-algo] Add new port #29717

Merged
merged 10 commits into from
Feb 21, 2023
Merged

[uni-algo] Add new port #29717

merged 10 commits into from
Feb 21, 2023

Conversation

mg152
Copy link
Contributor

@mg152 mg152 commented Feb 17, 2023

Fixes #29716

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Tested on:
Windows MSVC 19.16 (triplets: x86-windows, x64-windows, x64-windows-release)
Windows MinGW GCC 12.1 (triplets: x64-mingw-static, x64-mingw-dynamic)
Linux GCC 12.2 (triplets: x64-linux, x64-linux-dynamic, x64-linux-release)
Tested in both classic and manifest modes of vcpkg.
Everything seems to be fine.

mg152 added 6 commits February 17, 2023 17:01
@mg152
[uni-algo] Add new port
5195ca5
@mg152
[uni-algo] Update hash
5ef603f
@mg152
[uni-algo] Remove header-only feature
564cdd9 
vcpkg maintainer-guide.md: Do not use features to implement alternatives
Header-only/constexpr feature in v0.7.0 doesn't implement
one system locale function so it violates this rule.
@mg152
[uni-algo] Clean excessive comments
0d25f0c 
vcpkg maintainer-guide.md: Avoid excessive comments in portfiles
@mg152
[uni-algo] Format json
ce7b1e7
@mg152
[uni-algo] Update baseline
2d732ec 
Run: vcpkg x-add-version uni-algo
@mg152
Copy link
Contributor Author

mg152 commented Feb 17, 2023

@microsoft-github-policy-service agree

@mg152 mg152 marked this pull request as ready for review February 17, 2023 14:37
@FrankXie05 FrankXie05 self-assigned this Feb 20, 2023
@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 20, 2023
FrankXie05
FrankXie05 requested changes Feb 20, 2023
View reviewed changes
ports/uni-algo/portfile.cmake Outdated Show resolved Hide resolved
ports/uni-algo/portfile.cmake Show resolved Hide resolved
ports/uni-algo/usage Show resolved Hide resolved
ports/uni-algo/vcpkg.json Show resolved Hide resolved
@mg152 mg152 requested a review from FrankXie05 February 20, 2023 18:37
@FrankXie05
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FrankXie05
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FrankXie05 FrankXie05 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 21, 2023
@JavierMatosD JavierMatosD merged commit fd5058a into microsoft:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@FrankXie05 FrankXie05 FrankXie05 approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Port Request] uni-algo
4 participants
@mg152 @FrankXie05 @dg0yt @JavierMatosD