Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libtorch] Fix libtorch build #29497

Merged
merged 2 commits into from
Feb 8, 2023
Merged

[libtorch] Fix libtorch build #29497

merged 2 commits into from
Feb 8, 2023

Conversation

jimwang118
Copy link
Contributor

@jimwang118 jimwang118 commented Feb 7, 2023

Fixes #29440.
Fix libtocrch build failed with the following error.

CMake Error at caffe2/CMakeLists.txt:1419 (target_link_libraries):
Target "torch_cpu" links to:

zstd::libzstd_static
but the target was not found. Possible reasons include:

* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • [] Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@jimwang118 jimwang118 changed the title Fixlibtorch [libtorch] Fix libtorch build Feb 7, 2023
@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Feb 7, 2023
@jimwang118
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@jimwang118 jimwang118 marked this pull request as ready for review February 8, 2023 08:26
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Feb 8, 2023
@JavierMatosD JavierMatosD merged commit 2196a2c into microsoft:master Feb 8, 2023
@jimwang118 jimwang118 deleted the fixlibtorch branch April 23, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libtorch] build failure:zstd::libzstd_static
3 participants