Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libsmacker] add new port #29478

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Conversation

dbarkar
Copy link
Contributor

@dbarkar dbarkar commented Feb 6, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@dbarkar
Copy link
Contributor Author

dbarkar commented Feb 6, 2023

@microsoft-github-policy-service agree

@dbarkar dbarkar marked this pull request as ready for review February 6, 2023 18:12
@dbarkar
Copy link
Contributor Author

dbarkar commented Feb 6, 2023

This is my first port, please let me know if I can make it better :)

@dg0yt
Copy link
Contributor

dg0yt commented Feb 6, 2023

Doesn't it build with its native build system and vcpkg_configure_make et al.?

@dbarkar
Copy link
Contributor Author

dbarkar commented Feb 6, 2023

It's just few files, I thought it would be better to write proper CMakeLists.txt and avoid autotools.
p.s> I tried vcpkg_configure_make and couldn't make it work with MSVC, is it supposed to work? If you believe that it's the best way, I can try and rework this port.

@dg0yt
Copy link
Contributor

dg0yt commented Feb 6, 2023

I tried vcpkg_configure_make and couldn't make it work with MSVC, is it supposed to work? If you believe that it's the best way, I can try and rework this port.

I cannot give the ultimate answer. I know about the pain with autotools on Windows, and some projects can't be made work at all. But having a vendored build system in vcpkg has downsides, too.

ports/libsmacker/CMakeLists.txt Outdated Show resolved Hide resolved
ports/libsmacker/portfile.cmake Outdated Show resolved Hide resolved
ports/libsmacker/portfile.cmake Outdated Show resolved Hide resolved
ports/libsmacker/portfile.cmake Outdated Show resolved Hide resolved
ports/libsmacker/portfile.cmake Outdated Show resolved Hide resolved
@Adela0814 Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 7, 2023
ports/libsmacker/CMakeLists.txt Outdated Show resolved Hide resolved
@dbarkar dbarkar requested a review from Adela0814 February 7, 2023 10:56
@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 8, 2023
@JavierMatosD JavierMatosD merged commit 8e986ec into microsoft:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants