-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libsmacker] add new port #29478
[libsmacker] add new port #29478
Conversation
@microsoft-github-policy-service agree |
This is my first port, please let me know if I can make it better :) |
Doesn't it build with its native build system and |
It's just few files, I thought it would be better to write proper CMakeLists.txt and avoid autotools. |
I cannot give the ultimate answer. I know about the pain with autotools on Windows, and some projects can't be made work at all. But having a vendored build system in vcpkg has downsides, too. |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.