Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[open-dis-cpp] add new port #29472

Merged
merged 20 commits into from
Feb 8, 2023
Merged

Conversation

wadehunk
Copy link
Contributor

@wadehunk wadehunk commented Feb 6, 2023

Fixes #29471

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@wadehunk
Copy link
Contributor Author

wadehunk commented Feb 6, 2023

@microsoft-github-policy-service agree

github-actions[bot]
github-actions bot previously approved these changes Feb 7, 2023
@JonLiu1993 JonLiu1993 changed the title open-dis-cpp port [open-dis-cpp] add new port Feb 7, 2023
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 7, 2023
@JonLiu1993
Copy link
Member

@wadehunk, Thanks for your PR, please let me know if this PR is ready for review.

@wadehunk wadehunk marked this pull request as ready for review February 7, 2023 04:19
@wadehunk
Copy link
Contributor Author

wadehunk commented Feb 7, 2023

@JonLiu1993 Ready for review

github-actions[bot]
github-actions bot previously approved these changes Feb 7, 2023
@wadehunk
Copy link
Contributor Author

wadehunk commented Feb 7, 2023

Responding...

@wadehunk
Copy link
Contributor Author

wadehunk commented Feb 7, 2023

@JonLiu1993 Saw the requires:author-response label was added. Is there something I need to adjust?

@JonLiu1993
Copy link
Member

JonLiu1993 commented Feb 8, 2023

Tested usage by open-dis-cpp:x64-windows triplet successfully:

Total install time: 1.043 min
The package open-dis-cpp provides CMake targets:

    find_package(OpenDIS CONFIG REQUIRED)
    target_link_libraries(main PRIVATE OpenDIS::OpenDIS6)
    target_link_libraries(main PRIVATE OpenDIS::OpenDIS7)

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Feb 8, 2023
@JavierMatosD JavierMatosD merged commit 928c150 into microsoft:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] open-dis-cpp
3 participants