Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iceoryx] Fix acl dependency #29405

Merged
merged 2 commits into from
Feb 4, 2023
Merged

[iceoryx] Fix acl dependency #29405

merged 2 commits into from
Feb 4, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Feb 2, 2023

Alternative to #29257

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support labels Feb 3, 2023
@BillyONeal
Copy link
Member

Based on the discussion on my commit would it make sense to use the variables form instead of the target so that downstream consumption doesn't need to have pkgconfig available?

@dg0yt
Copy link
Contributor Author

dg0yt commented Feb 3, 2023

That's why I adopted the simplest approach with targets:

  • I learned that this dependency is linux-only. IMO it is fairly safe to assume the presence of pkg-config on linux.
  • I checked that IMPORTED_TARGET is available in CMake 3.7.
  • I know that the lib related variables from pkg_check_modules do have at least one open issue. IIRC the last remaining one is absolute file paths (/foo/libbar.a) not being added to <Pkg>_LINK_LIBRARIES.

OTOH if we really want variables:

  • I do have code (patch in port curl, upstreamed in gdal) which resolves deep target link libraries including typical generator expressions into flat variables. This could be generalized and made available via find_package if needed more often.
  • We already have a port file function x_pkgconfig_get modules which can give us the variable values to pass them into the iceoryx build. This is easy to adopt if desired.

@BillyONeal
Copy link
Member

OK, I'm sold that this approach is OK. I do want to see if I can move the dependency to the right place in iceoryx to resolve the "why does cyclonedds need this" feedback from @ex-purple before proceeding, investigating..

@BillyONeal BillyONeal merged commit e1ba85a into microsoft:master Feb 4, 2023
@BillyONeal
Copy link
Member

Thanks!

@dg0yt dg0yt deleted the iceoryx branch February 4, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants