Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kdalgorithms] Add new port #29375

Merged
merged 8 commits into from
Feb 3, 2023
Merged

Conversation

hmoffatt
Copy link
Contributor

@hmoffatt hmoffatt commented Feb 2, 2023

This is a header-only library with some stl algorithm wrappers.

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

github-actions[bot]
github-actions bot previously approved these changes Feb 2, 2023
@LilyWangLL LilyWangLL self-assigned this Feb 2, 2023
@LilyWangLL LilyWangLL changed the title new port: kdalgorithms [kdalgorithms] Add new port Feb 2, 2023
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 2, 2023
ports/kdalgorithms/portfile.cmake Outdated Show resolved Hide resolved
ports/kdalgorithms/portfile.cmake Outdated Show resolved Hide resolved
ports/kdalgorithms/portfile.cmake Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for kdalgorithms have changed but the version was not updated
version: 2023-01-31
old SHA: 7648cb03e208b5e45f0fc77629c514eb9308e0a5
new SHA: a16ec056f1bc26911b37f84d16a09852f0fb83cc
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for kdalgorithms have changed but the version was not updated
version: 2023-01-31
old SHA: 7648cb03e208b5e45f0fc77629c514eb9308e0a5
new SHA: 67805400ba6950a8cf7d2140553b49a0e556d7de
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for kdalgorithms have changed but the version was not updated
version: 2023-01-31
old SHA: 7648cb03e208b5e45f0fc77629c514eb9308e0a5
new SHA: f12630b2806a82732ae91e9550b23b8980f4bdb5
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

LilyWangLL
LilyWangLL previously approved these changes Feb 2, 2023
github-actions[bot]
github-actions bot previously approved these changes Feb 2, 2023
ports/kdalgorithms/usage Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 2, 2023
@BillyONeal BillyONeal merged commit 71d3fa6 into microsoft:master Feb 3, 2023
@BillyONeal
Copy link
Member

Thanks for the new port!

@hmoffatt hmoffatt deleted the kdalgorithms branch February 12, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants