[openslide] add port #29335
[openslide] add port #29335
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:
ports/openslide/vcpkg.json(has deprecated licenseLGPL-2.1)
Deprecated and non deprecated license identifiers can be found here
Cheney-W
added
the
category:new-port
…ake or pkgconfig. Resolves microsoft#29335 Alternate of microsoft#29258 @Neumann-A points out that controlling features through CMake configs and pkgconfig causes MSBuild customers to be left out in the cold. Moreover, attempting to add parenthesis to the SQLITE_API marco breaks autotools. This change makes such parenthesis unnecessary and ensures the configuration bits are used with automatic linking.
* [sqlite3] Control features with a configuration header rather than CMake or pkgconfig. Resolves #29335 Alternate of #29258 @Neumann-A points out that controlling features through CMake configs and pkgconfig causes MSBuild customers to be left out in the cold. Moreover, attempting to add parenthesis to the SQLITE_API marco breaks autotools. This change makes such parenthesis unnecessary and ensures the configuration bits are used with automatic linking. * Ensure feature controls affect the .c too, use less MAYBE_UNUSED. * Correctly note that zlib has no effect without tools. * Always add DL_LIBS even when static linking. * [sqlitecpp] Unconditionally enable column metadata because that is done in the sqlite3 port. * Add missing -l prefix on CMAKE_DL_LIBS
|
@BillyONeal Why did you close this one exactly? |
The usual "github closed it when the other PR merged for some reason" |
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:
ports/openslide/vcpkg.json(has deprecated licenseLGPL-2.1)
Deprecated and non deprecated license identifiers can be found here
|
Ah, I said 'resolves' there to indicate that it resolved the problem encountered here, but github interpreted that as 'this PR makes that other one obsolete'. Sorry about that! |
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:
ports/openslide/vcpkg.json(has deprecated licenseLGPL-2.1)
Deprecated and non deprecated license identifiers can be found here
Co-authored-by: Cheney Wang <[email protected]>
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for openslide have changed but the version was not updated
version: 3.4.1
old SHA: 58a1c9a43c706ac929dc90fc8335c7aa20ce2dbe
new SHA: e709084d5ff53f55afd332eac4b43ed9bf79e199
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, allfind_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says.The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context../vcpkg x-add-version --alland committing the result.probably blocked by #29258