Skip to content

[mchehab-zbar] Fix dependencies #29232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BillyONeal merged 1 commit into from
Feb 1, 2023
Merged

[mchehab-zbar] Fix dependencies #29232

BillyONeal merged 1 commit into from
Feb 1, 2023

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jan 28, 2023

msys2 dev lib dependency found while working at #29067.
Build locally tested on x64-linux host with mingw and linux triplets.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt
[mchehab-zbar] Fix dependencies
4e4dfee 
Do not use msys devel packages.
@MonicaLiu0311 MonicaLiu0311 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 29, 2023
@MonicaLiu0311
Copy link
Contributor

MonicaLiu0311 commented Jan 30, 2023

Feature nls is tested successfully in the following triplet:
x86-windows
x64-windows
x64-windows-static

@MonicaLiu0311 MonicaLiu0311 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 30, 2023
BillyONeal
BillyONeal approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ports/mchehab-zbar/portfile.cmake
@@ -1,11 +1,7 @@
if(EXISTS ${CURRENT_INSTALLED_DIR}/share/zbar/copyright)
message(FATAL_ERROR "${PORT} conflicts with zbar. Please remove zbar before installing ${PORT}.")
Copy link
Member

@BillyONeal BillyONeal Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, this block seems to predate the entire idea of versioning :)

@BillyONeal BillyONeal merged commit cda6c1f into microsoft:master Feb 1, 2023
@dg0yt dg0yt deleted the mchehab-zbar branch February 1, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

+1 more reviewer

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dg0yt @MonicaLiu0311 @BillyONeal