Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure-iot-sdk-c] LTS_01_2023_REF01 #29046

Merged
merged 43 commits into from
Feb 3, 2023
Merged

Conversation

JoseSanchez7
Copy link
Contributor

[azure-iot-sdk-c] LTS_01_2023_REF01

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout d8c61f7fbf9240389b0205a923b7706f0bfbf1f5 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/azure-c-shared-utility.json b/versions/a-/azure-c-shared-utility.json
index d140703..a0fffa1 100644
--- a/versions/a-/azure-c-shared-utility.json
+++ b/versions/a-/azure-c-shared-utility.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "2cd748787dbcbb7e47afa20f7b21818ce2d1c32d",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "2bfbac018e320a4f8d18aba279855bebd798e74f",
       "version-date": "2022-09-15",
diff --git a/versions/a-/azure-iot-sdk-c.json b/versions/a-/azure-iot-sdk-c.json
index d6605d0..877348b 100644
--- a/versions/a-/azure-iot-sdk-c.json
+++ b/versions/a-/azure-iot-sdk-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "8bf49fe94cff0133a07607eb1682005fee4d765c",
+      "version-date": "2023-01-18",
+      "port-version": 1
+    },
     {
       "git-tree": "9cb7368d6494ab01b085cad166bb7fef06cd14e7",
       "version-date": "2022-09-15",
diff --git a/versions/a-/azure-macro-utils-c.json b/versions/a-/azure-macro-utils-c.json
index f0dd734..02bb0e4 100644
--- a/versions/a-/azure-macro-utils-c.json
+++ b/versions/a-/azure-macro-utils-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "80a91308314a9254098b73a0215f21bab6fb4787",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "0c90715278e5ab77af983254bdf17571bf69c55b",
       "version-date": "2022-01-21",
diff --git a/versions/a-/azure-uamqp-c.json b/versions/a-/azure-uamqp-c.json
index 0d03937..8af5509 100644
--- a/versions/a-/azure-uamqp-c.json
+++ b/versions/a-/azure-uamqp-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "b229b4dada0d4ce287ccbed879d8c5b4638dfc60",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "42efba430e30e78eaf72b03c94f8c4afe07bcfda",
       "version-date": "2022-09-15",
diff --git a/versions/a-/azure-uhttp-c.json b/versions/a-/azure-uhttp-c.json
index ae63cab..4a5996b 100644
--- a/versions/a-/azure-uhttp-c.json
+++ b/versions/a-/azure-uhttp-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "8ba6fce12a13e816765590a12e53632e804c29cf",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "5c83542c6dc2b853932ac25c4d8314a5556aab40",
       "version-date": "2022-09-15",
diff --git a/versions/a-/azure-umqtt-c.json b/versions/a-/azure-umqtt-c.json
index a010bbe..d5e7fdf 100644
--- a/versions/a-/azure-umqtt-c.json
+++ b/versions/a-/azure-umqtt-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6f0080f27dd6366cfd832d78135800febc83e2cb",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "28ef0c8d4778d3fd30120290bcb4a121a2efc14f",
       "version-date": "2022-09-15",
diff --git a/versions/baseline.json b/versions/baseline.json
index fa32317..d8be414 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -353,7 +353,7 @@
       "port-version": 0
     },
     "azure-c-shared-utility": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "azure-core-cpp": {
@@ -369,7 +369,7 @@
       "port-version": 0
     },
     "azure-iot-sdk-c": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 1
     },
     "azure-kinect-sensor-sdk": {
@@ -377,7 +377,7 @@
       "port-version": 4
     },
     "azure-macro-utils-c": {
-      "baseline": "2022-01-21",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "azure-security-attestation-cpp": {
@@ -421,15 +421,15 @@
       "port-version": 0
     },
     "azure-uamqp-c": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "azure-uhttp-c": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "azure-umqtt-c": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "b64": {
@@ -7797,7 +7797,7 @@
       "port-version": 2
     },
     "umock-c": {
-      "baseline": "2022-01-21",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "unicorn": {
diff --git a/versions/u-/umock-c.json b/versions/u-/umock-c.json
index 3668261..6c9ed7b 100644
--- a/versions/u-/umock-c.json
+++ b/versions/u-/umock-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "1c72611607439f418348ff356a6638a6b63fb367",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "67f2fda1636719281706ebef0314a388ba5c8d15",
       "version-date": "2022-01-21",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/azure-macro-utils-c/vcpkg.json
  • ports/umock-c/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout d8c61f7fbf9240389b0205a923b7706f0bfbf1f5 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/azure-c-shared-utility.json b/versions/a-/azure-c-shared-utility.json
index d140703..a0fffa1 100644
--- a/versions/a-/azure-c-shared-utility.json
+++ b/versions/a-/azure-c-shared-utility.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "2cd748787dbcbb7e47afa20f7b21818ce2d1c32d",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "2bfbac018e320a4f8d18aba279855bebd798e74f",
       "version-date": "2022-09-15",
diff --git a/versions/a-/azure-iot-sdk-c.json b/versions/a-/azure-iot-sdk-c.json
index d6605d0..877348b 100644
--- a/versions/a-/azure-iot-sdk-c.json
+++ b/versions/a-/azure-iot-sdk-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "8bf49fe94cff0133a07607eb1682005fee4d765c",
+      "version-date": "2023-01-18",
+      "port-version": 1
+    },
     {
       "git-tree": "9cb7368d6494ab01b085cad166bb7fef06cd14e7",
       "version-date": "2022-09-15",
diff --git a/versions/a-/azure-uamqp-c.json b/versions/a-/azure-uamqp-c.json
index 0d03937..8af5509 100644
--- a/versions/a-/azure-uamqp-c.json
+++ b/versions/a-/azure-uamqp-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "b229b4dada0d4ce287ccbed879d8c5b4638dfc60",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "42efba430e30e78eaf72b03c94f8c4afe07bcfda",
       "version-date": "2022-09-15",
diff --git a/versions/a-/azure-uhttp-c.json b/versions/a-/azure-uhttp-c.json
index ae63cab..4a5996b 100644
--- a/versions/a-/azure-uhttp-c.json
+++ b/versions/a-/azure-uhttp-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "8ba6fce12a13e816765590a12e53632e804c29cf",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "5c83542c6dc2b853932ac25c4d8314a5556aab40",
       "version-date": "2022-09-15",
diff --git a/versions/a-/azure-umqtt-c.json b/versions/a-/azure-umqtt-c.json
index a010bbe..d5e7fdf 100644
--- a/versions/a-/azure-umqtt-c.json
+++ b/versions/a-/azure-umqtt-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6f0080f27dd6366cfd832d78135800febc83e2cb",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "28ef0c8d4778d3fd30120290bcb4a121a2efc14f",
       "version-date": "2022-09-15",
diff --git a/versions/baseline.json b/versions/baseline.json
index d0218c5..ca7d149 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -353,7 +353,7 @@
       "port-version": 0
     },
     "azure-c-shared-utility": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "azure-core-cpp": {
@@ -369,7 +369,7 @@
       "port-version": 0
     },
     "azure-iot-sdk-c": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 1
     },
     "azure-kinect-sensor-sdk": {
@@ -421,15 +421,15 @@
       "port-version": 0
     },
     "azure-uamqp-c": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "azure-uhttp-c": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "azure-umqtt-c": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "b64": {
@@ -7797,7 +7797,7 @@
       "port-version": 2
     },
     "umock-c": {
-      "baseline": "2022-01-21",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "unicorn": {
diff --git a/versions/u-/umock-c.json b/versions/u-/umock-c.json
index 3668261..6c9ed7b 100644
--- a/versions/u-/umock-c.json
+++ b/versions/u-/umock-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "1c72611607439f418348ff356a6638a6b63fb367",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "67f2fda1636719281706ebef0314a388ba5c8d15",
       "version-date": "2022-01-21",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/umock-c/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout d8c61f7fbf9240389b0205a923b7706f0bfbf1f5 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/azure-c-shared-utility.json b/versions/a-/azure-c-shared-utility.json
index d140703..a0fffa1 100644
--- a/versions/a-/azure-c-shared-utility.json
+++ b/versions/a-/azure-c-shared-utility.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "2cd748787dbcbb7e47afa20f7b21818ce2d1c32d",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "2bfbac018e320a4f8d18aba279855bebd798e74f",
       "version-date": "2022-09-15",
diff --git a/versions/a-/azure-iot-sdk-c.json b/versions/a-/azure-iot-sdk-c.json
index d6605d0..877348b 100644
--- a/versions/a-/azure-iot-sdk-c.json
+++ b/versions/a-/azure-iot-sdk-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "8bf49fe94cff0133a07607eb1682005fee4d765c",
+      "version-date": "2023-01-18",
+      "port-version": 1
+    },
     {
       "git-tree": "9cb7368d6494ab01b085cad166bb7fef06cd14e7",
       "version-date": "2022-09-15",
diff --git a/versions/a-/azure-uamqp-c.json b/versions/a-/azure-uamqp-c.json
index 0d03937..8af5509 100644
--- a/versions/a-/azure-uamqp-c.json
+++ b/versions/a-/azure-uamqp-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "b229b4dada0d4ce287ccbed879d8c5b4638dfc60",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "42efba430e30e78eaf72b03c94f8c4afe07bcfda",
       "version-date": "2022-09-15",
diff --git a/versions/a-/azure-uhttp-c.json b/versions/a-/azure-uhttp-c.json
index ae63cab..4a5996b 100644
--- a/versions/a-/azure-uhttp-c.json
+++ b/versions/a-/azure-uhttp-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "8ba6fce12a13e816765590a12e53632e804c29cf",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "5c83542c6dc2b853932ac25c4d8314a5556aab40",
       "version-date": "2022-09-15",
diff --git a/versions/a-/azure-umqtt-c.json b/versions/a-/azure-umqtt-c.json
index a010bbe..d5e7fdf 100644
--- a/versions/a-/azure-umqtt-c.json
+++ b/versions/a-/azure-umqtt-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6f0080f27dd6366cfd832d78135800febc83e2cb",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "28ef0c8d4778d3fd30120290bcb4a121a2efc14f",
       "version-date": "2022-09-15",
diff --git a/versions/baseline.json b/versions/baseline.json
index d0218c5..4b251bd 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -353,7 +353,7 @@
       "port-version": 0
     },
     "azure-c-shared-utility": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "azure-core-cpp": {
@@ -369,7 +369,7 @@
       "port-version": 0
     },
     "azure-iot-sdk-c": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 1
     },
     "azure-kinect-sensor-sdk": {
@@ -421,15 +421,15 @@
       "port-version": 0
     },
     "azure-uamqp-c": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "azure-uhttp-c": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "azure-umqtt-c": {
-      "baseline": "2022-09-15",
+      "baseline": "2023-01-18",
       "port-version": 0
     },
     "b64": {

	modified:   versions/a-/azure-c-shared-utility.json
	modified:   versions/a-/azure-iot-sdk-c.json
	modified:   versions/a-/azure-uamqp-c.json
	modified:   versions/a-/azure-uhttp-c.json
	modified:   versions/a-/azure-umqtt-c.json
	modified:   versions/baseline.json
github-actions[bot]
github-actions bot previously approved these changes Jan 18, 2023
@LilyWangLL LilyWangLL self-assigned this Jan 19, 2023
@LilyWangLL LilyWangLL added category:port-update The issue is with a library, which is requesting update new revision requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Jan 19, 2023
@JoseSanchez7
Copy link
Contributor Author

Hi @LilyWangLL , For umock-c and azure-macro-utils-c, we're still pointing to the same commit as before in our repos. So would it be okay not to update the ports for those, as I have done? Thanks.

@LilyWangLL
Copy link
Contributor

Hi @LilyWangLL , For umock-c and azure-macro-utils-c, we're still pointing to the same commit as before in our repos. So would it be okay not to update the ports for those, as I have done? Thanks.

We just need update ports which have new commit or release, if umock-c and azure-macro-utils-c have no new change, you don't need change them.

ports/azure-iot-sdk-c/vcpkg.json Outdated Show resolved Hide resolved
Co-authored-by: Lily Wang <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout d8c61f7fbf9240389b0205a923b7706f0bfbf1f5 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/azure-iot-sdk-c.json b/versions/a-/azure-iot-sdk-c.json
index 877348b..73a804e 100644
--- a/versions/a-/azure-iot-sdk-c.json
+++ b/versions/a-/azure-iot-sdk-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "c0e747b46da1a6642cce7718381c89ee08e29a5c",
+      "version-date": "2023-01-18",
+      "port-version": 0
+    },
     {
       "git-tree": "8bf49fe94cff0133a07607eb1682005fee4d765c",
       "version-date": "2023-01-18",
diff --git a/versions/baseline.json b/versions/baseline.json
index f33998a..26e1671 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -370,7 +370,7 @@
     },
     "azure-iot-sdk-c": {
       "baseline": "2023-01-18",
-      "port-version": 1
+      "port-version": 0
     },
     "azure-kinect-sensor-sdk": {
       "baseline": "1.4.1",

	modified:   versions/a-/azure-iot-sdk-c.json
	modified:   versions/baseline.json
github-actions[bot]
github-actions bot previously approved these changes Jan 19, 2023
@LilyWangLL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangLL
Copy link
Contributor

Is the feature public-preview still needed? I found that when these azure* ports updating to new version, this feature has no change, and its dependencies also need to be handled.

@JoseSanchez7
Copy link
Contributor Author

Is the feature public-preview still needed? I found that when these azure* ports updating to new version, this feature has no change, and its dependencies also need to be handled.

Could you please clarify a bit more? Are you suggesting that the two options available are to either remove public-preview if it's no longer needed, and update vcpkg accordingly, or, if we're going to keep public-preview, then handle its dependencies?

@JoseSanchez7
Copy link
Contributor Author

Is the feature public-preview still needed? I found that when these azure* ports updating to new version, this feature has no change, and its dependencies also need to be handled.

We will be keeping the public-preview feature. So what it is we need to do now in order to be able to merge this PR?

@BillyONeal
Copy link
Member

Is the feature public-preview still needed? I found that when these azure* ports updating to new version, this feature has no change, and its dependencies also need to be handled.

We will be keeping the public-preview feature. So what it is we need to do now in order to be able to merge this PR?

It seems that either the public preview should have its version updated to whatever the version after the one you're updating here is set to, or it should be outright removed. If you're editing the port yourself to change the ref you may as well just change the thing directly without the feature.

github-actions[bot]
github-actions bot previously approved these changes Feb 3, 2023
ewertons
ewertons previously approved these changes Feb 3, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for azure-macro-utils-c have changed but the version was not updated
version: 2022-01-21
old SHA: b6a332cf769a3cf6a8976dbab03e211cfe08d103
new SHA: 16d2dfb8fcb0ce81531684513a842841e30e9dd8
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for umock-c have changed but the version was not updated
version: 2022-01-21
old SHA: f6ab05f2f528e5423952ca3191af23a0e69a1953
new SHA: d1b765278c5bc0ca64ff6eec42d65d3ec836fec8
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for azure-macro-utils-c have changed but the version was not updated
version: 2022-01-21
old SHA: b6a332cf769a3cf6a8976dbab03e211cfe08d103
new SHA: 16d2dfb8fcb0ce81531684513a842841e30e9dd8
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for umock-c have changed but the version was not updated
version: 2022-01-21
old SHA: f6ab05f2f528e5423952ca3191af23a0e69a1953
new SHA: f8744584bc06f347a77f59ecfe150c15b2307b03
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for azure-macro-utils-c have changed but the version was not updated
version: 2022-01-21
old SHA: b6a332cf769a3cf6a8976dbab03e211cfe08d103
new SHA: 38ffed1b2623d28120cfadb97c2576a19b867f0c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Feb 3, 2023
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@BillyONeal BillyONeal dismissed LilyWangLL’s stale review February 3, 2023 20:07

public-preview was removed

@BillyONeal BillyONeal merged commit 2f0bcab into microsoft:master Feb 3, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Feb 6, 2023
BillyONeal pushed a commit that referenced this pull request Jun 12, 2024
…isioning client (#38841)

The `use-prov-client` feature in the `vcpkg.json` manifest file was
removed in PR #29046, ~probably by mistake when removing the
`public-preview` feature,~ and therefore it is not possible to enable
the device provisioning client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants