-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[imageinfo] Add new port #29009
[imageinfo] Add new port #29009
Conversation
f61670a
to
9900417
Compare
9900417
to
d9559e5
Compare
@JonLiu1993 Please re-review. |
d9559e5
to
d42b773
Compare
@JonLiu1993 @dg0yt Please re-review |
e33c97a
to
d766350
Compare
@dg0yt Done |
d766350
to
aa9a252
Compare
Tested usage by |
fdbd44c
aa9a252
to
fdbd44c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just confirm that the usage text looks good and we'll land this for you. Thanks for your contribution to vcpkg!
- Changes comply with the maintainer guide
- The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
There is a repology entry for this which refers to http://www.wohlberg.net/public/software/photo/imageinfo/ but that seems like it has not changed since 2006, so I think it's OK for this to 'usurp' the name given that it's the first hit for a search for "imageinfo C++" - Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx - The versioning scheme in
vcpkg.json
matches what upstream says. - The license declaration in
vcpkg.json
matches what upstream says. - The installed as the "copyright" file matches what upstream says.
- The source code of the component installed comes from an authoritative source.
- The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context.
Please confirm that this is correct. You can either just comment that it looks good and I'll add a usage file for you, or you can add one.imageinfo provides CMake targets: find_package(imageinfo CONFIG REQUIRED) target_link_libraries(main PRIVATE imageinfo::imageinfo)
- The version database is fixed by rerunning
./vcpkg x-add-version --all
and committing the result. - Only one version is in the new port's versions file.
- Only one version is added to each modified port's versions file.
That's looks good for me. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for imageinfo have changed but the version was not updated
version: 2023-01-31
old SHA: 6ae9e7403eedca77913232ed50cb6e7180f88caa
new SHA: 7076e81b85ba4888e7bf3213aa9ac6ea521f1ea0
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for imageinfo have changed but the version was not updated
version: 2023-01-31
old SHA: 6ae9e7403eedca77913232ed50cb6e7180f88caa
new SHA: 66f45650934f8561d3779ca4a29d808b8d1cea98
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the usage file for me @JonLiu1993
Thanks for the new port! |
Thanks for all your guys! I am happy that this port can land. |
Describe the pull request
imageinfo is a cross platform header only c++ library to get image size and format without loading/decoding.
Supports avif, bmp, cur, dds, gif, hdr (pic), heic (heif), icns, ico, jp2, jpeg (jpg), jpx, ktx, png, psd, qoi, tga, tiff (tif), webp ...