Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imageinfo] Add new port #29009

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Conversation

xiaozhuai
Copy link
Contributor

Describe the pull request

imageinfo is a cross platform header only c++ library to get image size and format without loading/decoding.
Supports avif, bmp, cur, dds, gif, hdr (pic), heic (heif), icns, ico, jp2, jpeg (jpg), jpx, ktx, png, psd, qoi, tga, tiff (tif), webp ...

github-actions[bot]
github-actions bot previously approved these changes Jan 17, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 17, 2023
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 18, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 19, 2023
@xiaozhuai xiaozhuai requested a review from JonLiu1993 January 19, 2023 16:05
@xiaozhuai
Copy link
Contributor Author

@JonLiu1993 Please re-review.

github-actions[bot]
github-actions bot previously approved these changes Jan 28, 2023
@xiaozhuai
Copy link
Contributor Author

@JonLiu1993 @dg0yt Please re-review

github-actions[bot]
github-actions bot previously approved these changes Jan 28, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 28, 2023
@xiaozhuai
Copy link
Contributor Author

@dg0yt Done

github-actions[bot]
github-actions bot previously approved these changes Jan 29, 2023
JonLiu1993
JonLiu1993 previously approved these changes Jan 29, 2023
@JonLiu1993
Copy link
Member

Tested usage by imageinfo:x64-windows triplet successfully.

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 29, 2023
dg0yt
dg0yt previously approved these changes Jan 29, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 31, 2023
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just confirm that the usage text looks good and we'll land this for you. Thanks for your contribution to vcpkg!

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
    There is a repology entry for this which refers to http://www.wohlberg.net/public/software/photo/imageinfo/ but that seems like it has not changed since 2006, so I think it's OK for this to 'usurp' the name given that it's the first hit for a search for "imageinfo C++"
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context.
    Please confirm that this is correct. You can either just comment that it looks good and I'll add a usage file for you, or you can add one.
    imageinfo provides CMake targets:
    
        find_package(imageinfo CONFIG REQUIRED)
        target_link_libraries(main PRIVATE imageinfo::imageinfo)
    
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Feb 1, 2023
@xiaozhuai
Copy link
Contributor Author

imageinfo provides CMake targets:

    find_package(imageinfo CONFIG REQUIRED)
    target_link_libraries(main PRIVATE imageinfo::imageinfo)

That's looks good for me. Thank you.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for imageinfo have changed but the version was not updated
version: 2023-01-31
old SHA: 6ae9e7403eedca77913232ed50cb6e7180f88caa
new SHA: 7076e81b85ba4888e7bf3213aa9ac6ea521f1ea0
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for imageinfo have changed but the version was not updated
version: 2023-01-31
old SHA: 6ae9e7403eedca77913232ed50cb6e7180f88caa
new SHA: 66f45650934f8561d3779ca4a29d808b8d1cea98
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the usage file for me @JonLiu1993

@BillyONeal BillyONeal added the info:reviewed Pull Request changes follow basic guidelines label Feb 1, 2023
@BillyONeal BillyONeal merged commit a548ef5 into microsoft:master Feb 2, 2023
@BillyONeal
Copy link
Member

Thanks for the new port!

@xiaozhuai
Copy link
Contributor Author

Thanks for all your guys! I am happy that this port can land.

@xiaozhuai xiaozhuai deleted the dev-imageinfo branch February 2, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants