Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WasmEdge] Add new port #28668

Merged
merged 46 commits into from
Feb 1, 2023
Merged

[WasmEdge] Add new port #28668

merged 46 commits into from
Feb 1, 2023

Conversation

Pospelove
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/wasmedge/vcpkg.json b/ports/wasmedge/vcpkg.json
index 53e95eb..6a57de6 100644
--- a/ports/wasmedge/vcpkg.json
+++ b/ports/wasmedge/vcpkg.json
@@ -4,15 +4,6 @@
   "description": "WasmEdge is a high-performance WebAssembly runtime for edge computing.",
   "homepage": "WasmEdge.org",
   "license": "Apache-2.0",
-  "default-features": [
-    "tools",
-    "aot",
-    "plugins",
-    "examples",
-    "plugin-wasi-nn-backend-openvino",
-    "plugin-wasi-nn-backend-pytorch",
-    "plugin-wasi-nn-backend-tensorflowlite"
-  ],
   "dependencies": [
     {
       "name": "vcpkg-cmake",
@@ -23,16 +14,19 @@
       "host": true
     }
   ],
+  "default-features": [
+    "aot",
+    "examples",
+    "plugin-wasi-nn-backend-openvino",
+    "plugin-wasi-nn-backend-pytorch",
+    "plugin-wasi-nn-backend-tensorflowlite",
+    "plugins",
+    "tools"
+  ],
   "features": {
-    "tools": {
-      "description": "Build tools"
-    },
     "aot": {
       "description": "Build with the Ahead-of-Time compiler supporting"
     },
-    "plugins": {
-      "description": "Build plugins"
-    },
     "examples": {
       "description": "Build examples"
     },
@@ -47,6 +41,12 @@
     "plugin-wasi-nn-backend-tensorflowlite": {
       "description": "Build the TensorFlow Lite backend plugin for the WasmEdge WASI-NN extension",
       "supports": "linux"
+    },
+    "plugins": {
+      "description": "Build plugins"
+    },
+    "tools": {
+      "description": "Build tools"
     }
   }
 }
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f9bea5d58186dc14e7e33132e43b52222147f51e -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 9e83033..68fc4b1 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -8000,6 +8000,10 @@
       "baseline": "2022.03.21.00",
       "port-version": 0
     },
+    "wasmedge": {
+      "baseline": "2022-12-31",
+      "port-version": 0
+    },
     "wavelib": {
       "baseline": "2021-11-26",
       "port-version": 0

github-actions[bot]
github-actions bot previously approved these changes Jan 2, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for wasmedge have changed but the version was not updated
version: 2022-12-31
old SHA: e38a9fcbe5dda3bf6d5fafa99a80e52ab215689b
new SHA: 19c27fc96777b45d687c77b5d7df9620a94e0b8e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Jan 2, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 2, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 2, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 2, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for wasmedge have changed but the version was not updated
version: 2022-12-31
old SHA: 92dcd1350737b4c74eb86c61de85bf2f6fcb5bbe
new SHA: 53befca367bfc8196bfd892fe5ae247462559156
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Jan 28, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 28, 2023
@Pospelove
Copy link
Contributor Author

@Cheney-W

Cheney-W
Cheney-W previously approved these changes Jan 29, 2023
@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 29, 2023
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new port! Can you please do one of the following?

  • Change version-string to version (or version-semver if you can find docs somewhere by the project claiming that they do semver)
  • Just comment that the right thing is version, and I'll make the change for you

Thanks!

You might also want to add a usage file but that isn't a requirement.


  • Changes comply with the maintainer guide
    See version field comment.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
    • There is a find_package(Boost QUIET) but boost packages are listed as direct dependencies.
    • find_package(spdlog QUIET) but spdlog is listed as a hard dependency.
    • find_package(GTest QUIET) find_package(RapidJSON QUIET) both disabled by WASMEDGE_BUILD_TESTS being off-by-default
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context.
    No usage was generated. You might want to add one in the future but as everything else is OK and nothing inaccurate is generated, this LGTM
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@@ -0,0 +1,52 @@
{
"name": "wasmedge",
"version-string": "0.12.0-alpha.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a semantic version; should that be version or version-semver?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me check if version-semver would be ok with "-aplha.1" suffix

ports/wasmedge/vcpkg.json Outdated Show resolved Hide resolved
@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Feb 1, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for wasmedge have changed but the version was not updated
version: 0.12.0-alpha.1
old SHA: 655f570f437247ad7fb333e234adf8c1dd6208e9
new SHA: bdb470fe5d66d194689d4bdfd211dcc6f3d4357e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@Pospelove
Copy link
Contributor Author

@BillyONeal thanks for the review, set to semver

@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 1, 2023
@BillyONeal
Copy link
Member

BillyONeal commented Feb 1, 2023

@BillyONeal thanks for the review, set to semver

Thank you!

@BillyONeal BillyONeal merged commit 3029a0e into microsoft:master Feb 1, 2023
@Pospelove Pospelove deleted the wasmedge branch February 2, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants