Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scenepic] Add new port #28661

Merged
merged 12 commits into from
Jan 12, 2023
Merged

[Scenepic] Add new port #28661

merged 12 commits into from
Jan 12, 2023

Conversation

jnyfah
Copy link
Contributor

@jnyfah jnyfah commented Jan 1, 2023

Describe the pull request

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f9bea5d58186dc14e7e33132e43b52222147f51e -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 93033eb..98b24e9 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6814,7 +6814,7 @@
     },
     "scenepic": {
       "baseline": "1.0.16",
-      "port-version": 0
+      "port-version": 1
     },
     "scintilla": {
       "baseline": "4.4.6",
diff --git a/versions/s-/scenepic.json b/versions/s-/scenepic.json
index 5060e92..25dae85 100644
--- a/versions/s-/scenepic.json
+++ b/versions/s-/scenepic.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "7093cf88740bff9702864eec6324cca69d96b9c6",
+      "version": "1.0.16",
+      "port-version": 1
+    },
     {
       "git-tree": "3137db01cf54f3cbd2de244ab61428c4d62768a4",
       "version": "1.0.16",

github-actions[bot]
github-actions bot previously approved these changes Jan 1, 2023
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 3, 2023
@LilyWangLL LilyWangLL changed the title add [Scenepic] new port [Scenepic] Add new port Jan 3, 2023
ports/scenepic/vcpkg.json Outdated Show resolved Hide resolved
ports/scenepic/portfile.cmake Outdated Show resolved Hide resolved
ports/scenepic/portfile.cmake Show resolved Hide resolved
ports/scenepic/portfile.cmake Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for scenepic have changed but the version was not updated
version: 1.0.16
old SHA: 3137db01cf54f3cbd2de244ab61428c4d62768a4
new SHA: 0844f08d72aebaef17d43982e5accf496154afc4
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f9bea5d58186dc14e7e33132e43b52222147f51e -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 98b24e9..93033eb 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6814,7 +6814,7 @@
     },
     "scenepic": {
       "baseline": "1.0.16",
-      "port-version": 1
+      "port-version": 0
     },
     "scintilla": {
       "baseline": "4.4.6",

@jnyfah jnyfah requested review from github-actions[bot] and LilyWangLL and removed request for github-actions[bot] and LilyWangLL January 3, 2023 09:46
github-actions[bot]
github-actions bot previously approved these changes Jan 3, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 6, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 6, 2023
LilyWangLL
LilyWangLL previously approved these changes Jan 10, 2023
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 10, 2023
ports/scenepic/fix_dependencies.patch Outdated Show resolved Hide resolved
ports/scenepic/portfile.cmake Outdated Show resolved Hide resolved
ports/scenepic/portfile.cmake Outdated Show resolved Hide resolved
ports/scenepic/portfile.cmake Outdated Show resolved Hide resolved
ports/scenepic/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jan 10, 2023
@jnyfah jnyfah dismissed stale reviews from LilyWangLL and github-actions[bot] via e51fdb6 January 10, 2023 10:05
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for scenepic have changed but the version was not updated
version: 1.0.16
old SHA: 2a958a35e461f3e7d6f69b23a82b4c8099ad780d
new SHA: 6189e56611fc03461ca02be717dc2d430aaccd6e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@jnyfah jnyfah requested review from github-actions[bot] and dg0yt and removed request for github-actions[bot] January 10, 2023 10:09
@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 11, 2023
@vicroms vicroms merged commit b442de3 into microsoft:master Jan 12, 2023
@jnyfah jnyfah deleted the scenepic branch April 18, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] Scenepic
4 participants