Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[armadillo,ensmallen] Update #28599

Merged
merged 6 commits into from
Jan 4, 2023
Merged

[armadillo,ensmallen] Update #28599

merged 6 commits into from
Jan 4, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 28, 2022 •
edited
Loading

  • What does your PR fix?

    Update armadillo to 11.4.3.
    Fixes forwarding of static usage requirements via pkgconfig and CMake's FindArmadillo.cmake. Fixes [armadillo] libarmadillo.a contains undefined symbol #12457.
    Cleanup.

    Update ensmallen to 2.19.0.
    Fixes lookup and forwarding of static usage requirement wrt to armadillo.

github-actions[bot]
github-actions bot previously approved these changes Dec 28, 2022
View reviewed changes
@dg0yt dg0yt marked this pull request as draft December 28, 2022 16:57
github-actions[bot]
github-actions bot previously approved these changes Dec 28, 2022
View reviewed changes
@dg0yt dg0yt changed the title [armadillo] Update [armadillo,ensmallen] Update Dec 28, 2022
@dg0yt dg0yt marked this pull request as ready for review December 28, 2022 17:35
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Dec 29, 2022
LilyWangLL
LilyWangLL previously approved these changes Dec 29, 2022
View reviewed changes
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Dec 29, 2022
@dg0yt dg0yt mentioned this pull request Dec 29, 2022
Closed
@vicroms
Copy link
Member

vicroms commented Dec 29, 2022

Depends on #28522

@vicroms vicroms added the depends:different-pr This PR or Issue depends on a PR which has been filed label Dec 29, 2022
@dg0yt dg0yt dismissed stale reviews from LilyWangLL and github-actions[bot] via 77b4bb7 January 4, 2023 06:18
@dg0yt
Copy link
Contributor Author

dg0yt commented Jan 4, 2023

Depends on #28522

Resolved.

@LilyWangLL LilyWangLL removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Jan 4, 2023
@vicroms vicroms merged commit 0a27759 into microsoft:master Jan 4, 2023
@dg0yt dg0yt deleted the armadillo branch January 5, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@LilyWangLL LilyWangLL LilyWangLL left review comments

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[armadillo] libarmadillo.a contains undefined symbol
3 participants
@dg0yt @vicroms @LilyWangLL