-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BitSerializer] Update to v0.50 #28564
Conversation
ports/bitserializer/portfile.cmake
Outdated
if (${BUILD_CSV_ARCHIVE}) | ||
vcpkg_check_linkage(ONLY_STATIC_LIBRARY) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flipping linkage by feature doesn't look right. If everything else is header-only, why use if
at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was also doubt how will be right.
Thanks, fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second sight, what's the problem with the CSV lib? If it is only DLL symbol export, dynamic linkage might work well for systems other than windows, and the statement might be wrapped into if(VCPKG_TARGET_IS_WINDOWS)
. This pattern exists in some other ports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to export symbols on Windows, library doesn't have CMake code which support build shared library.
This is not big work, but as author, I don't see reasons to support shared linkage, the library is quite small.
If you know any cases where shared library will be useful even the library size is small, please let me know.
All features are tested successfully in the following triplet:
|
Tested usage successfully with |
Describe the pull request
What does your PR fix?
Updates BitSerializer to version 0.50
Which triplets are supported/not supported? Have you updated the CI baseline?
all (but only with static linkage)
,No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes