Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
FrankXie05
added
the
category:vcpkg-feature
FrankXie05
approved these changes
Dec 27, 2022
FrankXie05
added
the
info:needs-maintainer-attention
Contributor
|
Would you please also add |
vicroms
added
requires:vcpkg-team-review
vicroms
requested changes
Dec 29, 2022
| set(VCPKG_LIBRARY_LINKAGE static) | ||
|
|
||
| set(VCPKG_CMAKE_SYSTEM_NAME Darwin) | ||
| set(VCPKG_OSX_ARCHITECTURES arm64) |
Member
There was a problem hiding this comment.
This line should not be needed. If this is actually needed, then we should fix our toolchain.
Contributor
Author
There was a problem hiding this comment.
The variable is only used in vcpkg/scripts/cmake/vcpkg_configure_make.cmake
Contributor
Author
There was a problem hiding this comment.
The variable was introduced in #6275 but as far as I see it was not used in that PR 😕
vicroms
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more release triplets.