Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ableton] no werror et al #28480

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Conversation

autoantwort
Copy link
Contributor

@autoantwort autoantwort commented Dec 21, 2022

Fixes the build of windows for me

[4/7] C:\PROGRA~1\MIB055~1\2022\COMMUN~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\cl.exe   /TP -DLINKHUT_AUDIO_PLATFORM_ASIO=1 -DLINK_BUILD_VLD=0 -DLINK_PLATFORM_WINDOWS=1 -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS -IG:\vcpkg\vcpkg_installed\x64-windows\include\asiosdk\common -IG:\vcpkg\vcpkg_installed\x64-windows\include\asiosdk\host -IG:\vcpkg\vcpkg_installed\x64-windows\include\asiosdk\host\pc -IG:\vcpkg\buildtrees\ableton\src\825333bd28-828085aa86.clean\examples\linkaudio -external:IG:\vcpkg\buildtrees\ableton\src\825333bd28-828085aa86.clean\include -external:IG:\vcpkg\vcpkg_installed\x64-windows\share\asio\..\..\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /MP /Wall /WX /EHsc /wd4061 /wd4265 /wd4350 /wd4355 /wd4365 /wd4371 /wd4503 /wd4510 /wd4512 /wd4514 /wd4571 /wd4610 /wd4625 /wd4626 /wd4628 /wd4640 /wd4710 /wd4711 /wd4723 /wd4738 /wd4820 /wd4996 /wd5045 /wd5204 /wd4464 /wd4548 /wd4623 /wd4868 /wd5026 /wd5027 /wd4987 /wd4774 /wd5039 /wd4127 /wd4242 /wd4619 /wd4668 /wd4702 /wd4946 /wd4267 /wd4477 /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /DDEBUG=1 /showIncludes /Foexamples\CMakeFiles\LinkHut.dir\linkaudio\AudioEngine.cpp.obj /Fdexamples\CMakeFiles\LinkHut.dir\ /FS -c G:\vcpkg\buildtrees\ableton\src\825333bd28-828085aa86.clean\examples\linkaudio\AudioEngine.cpp
FAILED: examples/CMakeFiles/LinkHut.dir/linkaudio/AudioEngine.cpp.obj 
C:\PROGRA~1\MIB055~1\2022\COMMUN~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\cl.exe   /TP -DLINKHUT_AUDIO_PLATFORM_ASIO=1 -DLINK_BUILD_VLD=0 -DLINK_PLATFORM_WINDOWS=1 -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS -IG:\vcpkg\vcpkg_installed\x64-windows\include\asiosdk\common -IG:\vcpkg\vcpkg_installed\x64-windows\include\asiosdk\host -IG:\vcpkg\vcpkg_installed\x64-windows\include\asiosdk\host\pc -IG:\vcpkg\buildtrees\ableton\src\825333bd28-828085aa86.clean\examples\linkaudio -external:IG:\vcpkg\buildtrees\ableton\src\825333bd28-828085aa86.clean\include -external:IG:\vcpkg\vcpkg_installed\x64-windows\share\asio\..\..\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /MP /Wall /WX /EHsc /wd4061 /wd4265 /wd4350 /wd4355 /wd4365 /wd4371 /wd4503 /wd4510 /wd4512 /wd4514 /wd4571 /wd4610 /wd4625 /wd4626 /wd4628 /wd4640 /wd4710 /wd4711 /wd4723 /wd4738 /wd4820 /wd4996 /wd5045 /wd5204 /wd4464 /wd4548 /wd4623 /wd4868 /wd5026 /wd5027 /wd4987 /wd4774 /wd5039 /wd4127 /wd4242 /wd4619 /wd4668 /wd4702 /wd4946 /wd4267 /wd4477 /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /DDEBUG=1 /showIncludes /Foexamples\CMakeFiles\LinkHut.dir\linkaudio\AudioEngine.cpp.obj /Fdexamples\CMakeFiles\LinkHut.dir\ /FS -c G:\vcpkg\buildtrees\ableton\src\825333bd28-828085aa86.clean\examples\linkaudio\AudioEngine.cpp
G:\vcpkg\buildtrees\ableton\src\825333bd28-828085aa86.clean\examples\linkaudio\AudioEngine.cpp(140): error C2220: the following warning is treated as an error
G:\vcpkg\buildtrees\ableton\src\825333bd28-828085aa86.clean\examples\linkaudio\AudioEngine.cpp(140): warning C5264: 'double const `private: void __cdecl ableton::linkaudio::AudioEngine::renderMetronomeIntoBuffer(ableton::BasicLink<ableton::platforms::windows::Clock>::SessionState,double,std::chrono::duration<__int64,std::ratio<1,1000000> >,unsigned __int64)'::`2'::lowTone': 'const' variable is not used
G:\vcpkg\buildtrees\ableton\src\825333bd28-828085aa86.clean\examples\linkaudio\AudioEngine.cpp(140): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings
G:\vcpkg\buildtrees\ableton\src\825333bd28-828085aa86.clean\examples\linkaudio\AudioEngine.cpp(139): warning C5264: 'double const `private: void __cdecl ableton::linkaudio::AudioEngine::renderMetronomeIntoBuffer(ableton::BasicLink<ableton::platforms::windows::Clock>::SessionState,double,std::chrono::duration<__int64,std::ratio<1,1000000> >,unsigned __int64)'::`2'::highTone': 'const' variable is not used
G:\vcpkg\buildtrees\ableton\src\825333bd28-828085aa86.clean\examples\linkaudio\AudioEngine.cpp(139): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/ableton/portfile.cmake

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Dec 22, 2022
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Dec 22, 2022
@dan-shaw dan-shaw merged commit 6adca01 into microsoft:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants