Skip to content

[vcpkg baseline][ideviceinstaller] Fix LNK2019 in static triplet#28382

Merged
dan-shaw merged 4 commits intomicrosoft:masterfrom
Cheney-W:Dev/Cheney/CI
Dec 16, 2022
Merged

[vcpkg baseline][ideviceinstaller] Fix LNK2019 in static triplet#28382
dan-shaw merged 4 commits intomicrosoft:masterfrom
Cheney-W:Dev/Cheney/CI

Conversation

@Cheney-W
Copy link
Copy Markdown
Contributor

Describe the pull request

  • What does your PR fix?

    Fixes ideviceinstaller install failed with below errors in static triplet:
  imobiledevice-1.0.lib(socket.c.obj) : error LNK2019: unresolved external symbol __imp_accept referenced in function socket_accept
  libcrypto.lib(libcrypto-lib-e_capi.obj) : error LNK2019: unresolved external symbol __imp_CertOpenStore referenced in function capi_open_store

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Dec 16, 2022
@LilyWangLL LilyWangLL marked this pull request as ready for review December 16, 2022 10:39
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 16, 2022
@dan-shaw dan-shaw merged commit 3ffb147 into microsoft:master Dec 16, 2022
@Cheney-W Cheney-W deleted the Dev/Cheney/CI branch January 4, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants