Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simd] Add missing header files #28376

Merged
merged 4 commits into from
Dec 28, 2022
Merged

Conversation

JonLiu1993
Copy link
Member

Describe the pull request

When install simd, only SimdLib.hpp, missing a lot of header files. I add the missing header files.

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 16, 2022
github-actions[bot]
github-actions bot previously approved these changes Dec 16, 2022
@Thomas1664
Copy link
Contributor

@JonLiu1993
Copy link
Member Author

Furthermore, this port has a CMake build system: https://github.com/ermig1979/Simd/blob/96dfde3b243687d796426719cf354b47fd4cd727/prj/cmake/CMakeLists.txt

We will not consider replacing the cmake build system for this PR, maybe the next version update will consider doing so.

@JonLiu1993 JonLiu1993 marked this pull request as ready for review December 22, 2022 09:22
@JonLiu1993 JonLiu1993 requested a review from Adela0814 December 22, 2022 10:02
@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 23, 2022
@vicroms vicroms merged commit fa0931a into microsoft:master Dec 28, 2022
@JonLiu1993 JonLiu1993 deleted the dev/Jon/simd branch December 29, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Simd] Missing header files
4 participants