Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asio] add target guard for target asio::asio #28299

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

lesomnus
Copy link
Contributor

Describe the pull request

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@lesomnus
Copy link
Contributor Author

Is it OK to push x-add-version commit? or should I have to wait for someone's approval?

@JonLiu1993 JonLiu1993 self-assigned this Dec 13, 2022
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Dec 13, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for asio have changed but the version was not updated
version: 1.24.0
old SHA: bba8740d419878e427c71f076d569f8a26833c6b
new SHA: f4ac597317008cac0b781ffa1ce1a09e4bc3af87
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@JonLiu1993
Copy link
Member

@lesomnus, Thanks for your pr, please add "port version" : 1, to the vcpkg.json and run command "./vcpkg x-add-version asio --overwrite-version" and commit again.

@lesomnus
Copy link
Contributor Author

@microsoft-github-policy-service agree

@lesomnus lesomnus marked this pull request as ready for review December 13, 2022 06:42
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Dec 15, 2022
@dan-shaw dan-shaw merged commit cba75f1 into microsoft:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[asio] Prevent add_library(asio::asio) if target already exists.
3 participants