Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sse2neon] Fix sse2neon header install path #28268

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

jackgerrits
Copy link
Member

Describe the pull request

  • What does your PR fix?

    The DESTINATION parameter of file(COPY ... accepts a path. However, in the current portfile it was used as if it was the destination file location. This results in the final installed file location being:
installed/arm64-osx/include/sse2neon/sse2neon.h/sse2neon.h

Instead of what I assume to be the desired:

installed/arm64-osx/include/sse2neon/sse2neon.h

I updated the file(COPY ... call to install the header to the expected location.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    no change, yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@Cheney-W Cheney-W added category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines and removed category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. labels Dec 12, 2022
@dan-shaw dan-shaw merged commit d034400 into microsoft:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants