Skip to content

[vcpkg] Fix VS can still be IntelliSense after disabling vcpkg#28216

Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom
FrankXie05:dev/Frank/28200
Dec 8, 2022
Merged

[vcpkg] Fix VS can still be IntelliSense after disabling vcpkg#28216
dan-shaw merged 1 commit intomicrosoft:masterfrom
FrankXie05:dev/Frank/28200

Conversation

@FrankXie05
Copy link
Copy Markdown
Contributor

@FrankXie05 FrankXie05 commented Dec 7, 2022

Describe the pull request

  • What does your PR fix?

    Fixes vcpkg integrate bug #28200
    Note:
    After setting Use Vcpkg to No, the header path of vcpkg installed ports will not be deleted in the External Include Directories.
    This is due to the regression triggered by the PR [vcpkg] Fix external include path #21544 without setting conditions.
    Problems caused:
    The IntelliSense in the VS can still sense the library provided by the currently integrated vcpkg.

image
image

@FrankXie05 FrankXie05 added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal labels Dec 7, 2022
@FrankXie05 FrankXie05 changed the title [vcpkg] Fix integration in Visual Studio [vcpkg] Fix integration on build MSVC Dec 7, 2022
@FrankXie05 FrankXie05 changed the title [vcpkg] Fix integration on build MSVC [vcpkg] Fix after setting Use Vcpkg to No, the path of vcpkg integration will not be deleted in the External Include Directories. Dec 7, 2022
@FrankXie05 FrankXie05 changed the title [vcpkg] Fix after setting Use Vcpkg to No, the path of vcpkg integration will not be deleted in the External Include Directories. [vcpkg] Fix VS can still be IntelliSense after disabling vcpkg Dec 7, 2022
@FrankXie05
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@FrankXie05 FrankXie05 mentioned this pull request Dec 7, 2022
@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 7, 2022
@dan-shaw dan-shaw merged commit 30a20e8 into microsoft:master Dec 8, 2022
@FrankXie05 FrankXie05 deleted the dev/Frank/28200 branch December 8, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vcpkg integrate bug

3 participants