Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sse2neon] Add new port #28129

Merged
merged 1 commit into from
Dec 6, 2022
Merged

[sse2neon] Add new port #28129

merged 1 commit into from
Dec 6, 2022

Conversation

rami-lv
Copy link
Contributor

@rami-lv rami-lv commented Dec 2, 2022

Describe the pull request

  • What does your PR fix?

Add a new port

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all , NO

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 5, 2022
@Cheney-W
Copy link
Contributor

Cheney-W commented Dec 5, 2022

Please sign the CLA according to the robot's instructions.

@rami-lv
Copy link
Contributor Author

rami-lv commented Dec 5, 2022

Please sign the CLA according to the robot's instructions.

I am not quite sure of what submissions refer to here. I am not the owner of this library, however, the submission to add the library is mine but the library is not. Is it okay to proceed with this?

@Cheney-W
Copy link
Contributor

Cheney-W commented Dec 5, 2022

This is the requirement to submit PR for Microsoft repository. It has nothing to do with that port.

@rami-lv
Copy link
Contributor Author

rami-lv commented Dec 5, 2022

@microsoft-github-policy-service agree

github-actions[bot]
github-actions bot previously approved these changes Dec 5, 2022
@Cheney-W
Copy link
Contributor

Cheney-W commented Dec 6, 2022

Could you please apply my suggestion? Thank you!

@rami-lv
Copy link
Contributor Author

rami-lv commented Dec 6, 2022

Could you please apply my suggestion? Thank you!

I believe I had to run ./vcpkg x-add-version --all again right?

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Dec 6, 2022
@rami-lv rami-lv requested a review from Cheney-W December 6, 2022 12:24
@dan-shaw dan-shaw merged commit 559bd97 into microsoft:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants