Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joltphysics] Add usage #28050

Merged
merged 4 commits into from
Nov 29, 2022
Merged

[joltphysics] Add usage #28050

merged 4 commits into from
Nov 29, 2022

Conversation

Adela0814
Copy link
Contributor

Fixes: #28048

Added usage and tested on x64-windows.

@Adela0814 Adela0814 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Nov 29, 2022
@Adela0814 Adela0814 marked this pull request as ready for review November 29, 2022 06:00
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Nov 29, 2022
@skaarj1989
Copy link
Contributor

skaarj1989 commented Nov 29, 2022 •
edited
Loading

This is incomplete. An user needs to link against Jolt.lib
target_include_directories does not solve this.

@JavierMatosD
Copy link
Contributor

Thank you!

@JavierMatosD JavierMatosD merged commit be736ae into microsoft:master Nov 29, 2022
@Adela0814 Adela0814 deleted the Jolt branch January 16, 2023 06:20
@Honeybunch
Copy link
Contributor

This is incomplete. An user needs to link against Jolt.lib target_include_directories does not solve this.

I also believe this is incomplete. As a result I think this issue has been closed in error:
#28048

Unless I'm misunderstanding it seems like this port is partially malformed. There are no targets exported/installed by jolt so right now the user would have to manually find the dbg/rel libs and link them explicitly. Which is a pain. I can't imagine this is the first port that has had this problem? Is there a good example of how this should portfile should look?

@mdsitton
Copy link

Yeah i saw the suggested usage and immediately noticed something was wrong. So this needs to have a second look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[joltphysics] find_package doesn't work
7 participants
@Adela0814 @skaarj1989 @JavierMatosD @Honeybunch @mdsitton @JonLiu1993 @Mengna-Li