[Basisu] Fix MinGW build failure #27760
Conversation
|
@microsoft-github-policy-service agree |
| #include <ostream> | ||
|
|
||
| -#ifndef _WIN32 | ||
| +#if !defined(_WIN32) or defined(__MINGW32__) |
There was a problem hiding this comment.
Isn't the real problem that _WIN32should be defined also with mingw?
There was a problem hiding this comment.
_WIN32 is defined with MinGW, and this is exactly the problem, because the preprocessor directive will filter out the #include <libgen.h>, which is actually required when compiling with MinGW, but not with MSVC.
LilyWangLL
added
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for basisu have changed but the version was not updated
version: 1.11#7
old SHA: dd7b75c3af3acb98ce852f1b2fda02f47dc1a08e
new SHA: 51ced1494614fa6f9577fa01db67e97c0d025d17
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for fontconfig have changed but the version was not updated
version: 2.14.1
old SHA: 6e8409679e92c3870efcfeed43890c7f7bd92f43
new SHA: ddb70e87d9403156c85ca19ebca7c5d4232e49a3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
|
Thanks for your PR. Please also update |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for basisu have changed but the version was not updated
version: 1.11#7
old SHA: dd7b75c3af3acb98ce852f1b2fda02f47dc1a08e
new SHA: b7f17543156874a50027986946b22f161902dabf
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for fontconfig have changed but the version was not updated
version: 2.14.1
old SHA: 6e8409679e92c3870efcfeed43890c7f7bd92f43
new SHA: ddb70e87d9403156c85ca19ebca7c5d4232e49a3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
|
Ping @addowhite for response.
|
Will make the change to fontconfig in another branch This reverts commit 6894e45.
I intended this PR to be for Basisu only, I'll fix fontconfig separately. |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for basisu have changed but the version was not updated
version: 1.11#7
old SHA: dd7b75c3af3acb98ce852f1b2fda02f47dc1a08e
new SHA: 31adec97dda19e99a5745f46a5d2031981206bb1
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for basisu have changed but the version was not updated
version: 1.11#7
old SHA: 51ced1494614fa6f9577fa01db67e97c0d025d17
new SHA: 31adec97dda19e99a5745f46a5d2031981206bb1
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
|
I believe upstream already has this change as BinomialLLC/basis_universal@b32a0c1 Thanks! |
Describe the pull request
Basisu won't build with mingw triplet due to not including libgen.h on Windows.
However, the libgen include is required on Windows when using MinGW as it's needed for definitions of dirname() and basename().
This PR modifies src/encoder/basisu_enc.h so that it will include
libgen.hwhen compiled with MinGWWhat does your PR fix?
Fixes [Basisu] MinGW build failure #27759
Which triplets are supported/not supported? Have you updated the CI baseline?
<all, x64-mingw-dynamic>,
Does your PR follow the maintainer guide?
YesIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?