Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DiscordCoreAPI] Updating to version 2022-10-12 #27205

Merged
merged 11 commits into from
Oct 13, 2022
Merged

[DiscordCoreAPI] Updating to version 2022-10-12 #27205

merged 11 commits into from
Oct 13, 2022

Conversation

RealTimeChris
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

It adds some much needed comprehensive Https response message output as well as WebSocket close code messages.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    <linux-x64, windows-x64>,

  • Does your PR follow the maintainer guide?

    Yes, I believe it does.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes I have

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@RealTimeChris RealTimeChris changed the title Updating the necessary files. [DiscordCoreAPI] Updating to version 2022-10-12 Oct 12, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 680071397677bb123b2f2b0ebe73905feae4a955 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index aadc7d9..7dc2fc0 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1961,7 +1961,7 @@
       "port-version": 1
     },
     "discordcoreapi": {
-      "baseline": "2022-09-25",
+      "baseline": "2022-10-12",
       "port-version": 0
     },
     "discount": {

github-actions[bot]
github-actions bot previously approved these changes Oct 12, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for discordcoreapi have changed but the version was not updated
version: 2022-10-12
old SHA: b681ea98a08aac3968e3573b352d67cc6fd4eb8e
new SHA: adc141ac05d4500d1be3bc382b35885360ff4df0
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Oct 12, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 12, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 12, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 13, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Oct 13, 2022
@vicroms vicroms merged commit ddd7eb8 into microsoft:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants