Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[im3d] New port #27198

Merged
merged 6 commits into from
Oct 14, 2022
Merged

[im3d] New port #27198

merged 6 commits into from
Oct 14, 2022

Conversation

RT2Code
Copy link
Contributor

@RT2Code RT2Code commented Oct 12, 2022

  • What does your PR fix?

Add a new port : https://github.com/john-chapman/im3d

  • Which triplets are supported/not supported? Have you updated the [CI baseline]

All, Yes

  • Does your PR follow the [maintainer guide]

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

github-actions[bot]
github-actions bot previously approved these changes Oct 12, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/im3d/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Oct 12, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 12, 2022
@LilyWangLL LilyWangLL self-assigned this Oct 13, 2022
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 13, 2022
LilyWangLL
LilyWangLL previously approved these changes Oct 13, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Oct 13, 2022
ports/im3d/CMakeLists.txt Outdated Show resolved Hide resolved
ports/im3d/CMakeLists.txt Outdated Show resolved Hide resolved
ports/im3d/CMakeLists.txt Outdated Show resolved Hide resolved
ports/im3d/CMakeLists.txt Outdated Show resolved Hide resolved
ports/im3d/CMakeLists.txt Outdated Show resolved Hide resolved
ports/im3d/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for im3d have changed but the version was not updated
version: 2022-10-11
old SHA: 44e5ef787c49affa62bb3ba0a30e3ad173afae24
new SHA: 98557d4600a307373f8424d7d770bf4d64b04d10
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@vicroms vicroms merged commit 5aabf6d into microsoft:master Oct 14, 2022
@RT2Code RT2Code deleted the im3d branch October 14, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants