Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Document overlay ports/triplets in vcpkg-configuration.json #27172

Merged
merged 19 commits into from
Nov 11, 2022

Conversation

valeriaconde
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Fixes docs to reflect changes to overlays

  • Which triplets are supported/not supported? Have you updated the CI baseline?

n/a

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

n/a

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

docs/users/registries.md Outdated Show resolved Hide resolved
docs/users/registries.md Outdated Show resolved Hide resolved
docs/users/registries.md Outdated Show resolved Hide resolved
@vicroms vicroms changed the title Update registries.md [docs] Document overlay ports/triplets in vcpkg-configuration.json Oct 11, 2022
docs/users/registries.md Outdated Show resolved Hide resolved
docs/users/manifests.md Outdated Show resolved Hide resolved
docs/users/registries.md Outdated Show resolved Hide resolved
@valeriaconde valeriaconde marked this pull request as ready for review October 20, 2022 18:20
github-actions[bot]
github-actions bot previously approved these changes Oct 20, 2022
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried some suggestions to make overlays resolution clearer. Feel free to reword/rewrite as you see fit.

docs/users/registries.md Outdated Show resolved Hide resolved
docs/users/registries.md Outdated Show resolved Hide resolved
docs/users/registries.md Outdated Show resolved Hide resolved
vicroms
vicroms previously approved these changes Oct 24, 2022
@vicroms vicroms added requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof and removed requires:author-response labels Oct 24, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 24, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 25, 2022
vicroms
vicroms previously approved these changes Oct 25, 2022
docs/users/manifests.md Outdated Show resolved Hide resolved
@vicroms vicroms added the info:reviewed Pull Request changes follow basic guidelines label Oct 25, 2022
Co-authored-by: Victor Romero <[email protected]>
vicroms
vicroms previously approved these changes Oct 25, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 25, 2022
@BillyONeal
Copy link
Member

Dropping reviewed because this is already requires:vcpkg-tool-release.

@BillyONeal BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Oct 26, 2022
docs/users/registries.md Outdated Show resolved Hide resolved
docs/users/registries.md Outdated Show resolved Hide resolved
docs/users/registries.md Outdated Show resolved Hide resolved
@BillyONeal BillyONeal merged commit f7a537d into microsoft:master Nov 11, 2022
@BillyONeal
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:documentation To resolve the issue, documentation will need to be updated requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants